Don't truncate traces at span depth 4 - #493
Merged
Merged
Conversation
added 4 commits
August 26, 2026 16:28
Assisted-by: Claude:claude-opus-5
KodrAus
approved these changes
Aug 26, 2026
|
|
||
| var writer = new LoggerConfiguration() | ||
| .Destructure.With<JsonNetDestructuringPolicy>() | ||
| .Destructure.ToMaximumDepth(10000) |
Member
There was a problem hiding this comment.
Nobody will ever need an object nested to 10,000 levels
Member
There was a problem hiding this comment.
Might be good to derive this from the value we use as the span retrieval limit 🤔 ... I'll run through how that looks and include it in my next round 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Formatting via the Serilog logger inadvertently truncates traces at the logger's maximum destructuring depth.
We're always dealing with already-serialization-friendly data in this context, so there's not much to lose by relaxing the depth limit.