feat(hub-ui): adopt @antfu/design components and devframe branding - #176
Open
antfubot wants to merge 1 commit into
Open
feat(hub-ui): adopt @antfu/design components and devframe branding#176antfubot wants to merge 1 commit into
antfubot wants to merge 1 commit into
Conversation
Reuse the shared design system's Vue components in the dock shell instead of bespoke local ones, swap the placeholder plug glyph for the devframe logo, and drop the Vite-derived dock chrome. - Buttons across the launcher, confirm modal, auth notice and json-render now use @antfu/design's ActionButton; keybinding chips use DisplayKbd. - The shadow-root stylesheet build scans the design package's components so their semantic shortcut classes ship in the injected CSS. - BrandMark/BrandWordmark render the devframe logo mark. - Remove the dock brackets and re-theme the dock glow to the sage palette. Created with the help of an agent.
✅ Deploy Preview for devfra ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Refactors the hub-ui dock shell to lean on the shared devframe design system and to carry devframe's own branding rather than placeholder/Vite chrome.
Reuse
@antfu/designcomponentsButtonrenderer now use@antfu/design'sActionButton(primary/action/textvariants), replacing the bespoke localdisplay/Button.vue.@antfu/design'sDisplayKbd, replacing the localKeybindingBadge.scripts/build-css.ts) additionally scans the design package's component sources so their semantic shortcut classes (btn-primary,btn-action, …) ship in the injected stylesheet — UnoCSS ignoresnode_modulesby default, which would otherwise leave the reused components unstyled inside the shadow DOM.display/Button.vue,KeybindingBadge.vue, and their stories.devframe logo
DevframeLogo.vueinlines the devframe logo mark (per-instance unique gradient id).BrandMarkandBrandWordmarkrender it instead of thei-ph:plug-duotoneplaceholder glyph.Remove Vite theming
BracketLeft/BracketRighticon components and the[ … ]bracket chrome around the floating dock.Verification
build:css,typecheck,build(embedded + standalone),lint,knip, andbuild-storybookall pass. Browser screenshots weren't possible on this ARM64 host (no Chromium build available).Created with the help of an agent.