Fail closed when repository policy dependencies are missing - #114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
-configwere incorrectly treating anyos.ErrNotExistreturned while loading a config as if the top-level config was missing, which allowed scans to silently fall back to built-in defaults when repository policy dependencies (e.g. external design rules) were absent.Description
ErrConfigNotFoundreturned only when the top-level configuration file is absent and preserve underlyingos.ErrNotExistfor other missing artifacts by wrapping withfmt.Errorf("%w: %w", ErrConfigNotFound, err)ininternal/codeguard/config/io.go.pkg/codeguard/sdk_config.goasErrConfigNotFoundand updateinternal/cli/helpers.goto only allow configless fallback whenservice.ErrConfigNotFoundis returned.%wso callers can detect the sentinel reliably, and remove an unused import introduced during the change.TestRunScanFolderWithMissingDesignRulesDoesNotFallBackintests/cli/scan_test.gothat verifies a folder scan with an existing config referencing a missing design-rules file fails rather than falling back.Testing
go test ./...ran and completed successfully across packages.go test ./tests/cli ./tests/codeguardran and completed successfully, and the added regression test exercised the failure path as intended.Codex Task