fix(reliability): make goroutine-in-loop detection linear to avoid quadratic AST walks - #130
Merged
alxxjohn merged 1 commit intoAug 18, 2026
Conversation
alxxjohn
deleted the
alexj/propose-fix-for-reliability-scan-vulnerability
branch
August 18, 2026 23:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
isInsideLoop(which performed a fullast.Inspectover the function body) for every*ast.GoStmt, producing quadratic behavior and allowing attacker-controlled source to cause excessive CPU usage during reliability scans.Description
ast.Inspectpass by addingloopDepthandloopStackand checkingloopDepth > 0for goroutine-in-loop classification.isInsideLoopfromreliability_go_helpers.goand updatefunctionReliabilityFindingsinreliability_go.goto use the in-pass loop depth check instead of extra walks.reliability.unbounded-workand related checks) while changing only the detection mechanism to be linear in AST size.Testing
gofmt -w internal/codeguard/checks/reliability/*.goand it completed successfully.go test ./tests/checksand the test suite ran successfully in this environment.go test ./internal/codeguard/checks/reliabilitywhich reported there are no test files for that package, so no package-local tests were run.git diff --checkto ensure no whitespace or trivial issues and it reported no problems.Codex Task