fix(release): require protected release-publish environment for npm/PyPI OIDC publishing - #132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
id-token: write) without a GitHub environment constraint, which lets a workflow-dispatchable caller on an unprotected ref impersonate the trusted top-level workflow and publish packages.Description
environment: release-publishto thepublish-npmjob in.github/workflows/cd.yml.environment: release-publishto thepublish-pypijob in.github/workflows/cd.yml.packaging/README.mdto require therelease-publishenvironment for npm and PyPI trusted-publisher configuration and to recommend deployment branch protection and required reviewers for that environment.Testing
ruby -e 'require "yaml"; YAML.parse_file(".github/workflows/cd.yml")'and the YAML parsed successfully.git diff --checkand basic repository status checks which showed no diff errors.actionlintwas not available in the environment, so workflow static linting withactionlintwas not executed.Codex Task