Skip to content

Prevent tsconfig exclusions from bypassing TypeScript security scans #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alxxjohn merged 2 commits into from
Aug 19, 2026
Merged

Prevent tsconfig exclusions from bypassing TypeScript security scans #134

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a464824
fix: prevent tsconfig from narrowing security scans
alxxjohn Aug 19, 2026
6746a20
Merge main into tsconfig exclusion security fix
alxxjohn Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions internal/codeguard/checks/support/typescript_semantic_runner_core.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function loadProgram() {
configPath,
);
return ts.createProgram({
rootNames: configuredRootNames(parsed.fileNames, rootNames),
rootNames: rootNames || parsed.fileNames.filter((name) => isWithinTarget(path.resolve(name))),
options: parsed.options,
});
}
Expand All @@ -71,15 +71,6 @@ function loadProgram() {
});
}

function configuredRootNames(configuredFiles, corpusFiles) {
const withinTarget = configuredFiles.filter((name) => isWithinTarget(path.resolve(name)));
if (!Array.isArray(corpusFiles)) {
return withinTarget;
}
const corpus = new Set(corpusFiles.map((name) => path.resolve(name)));
return withinTarget.filter((name) => corpus.has(path.resolve(name)));
}

function findConfigPath() {
return ts.findConfigFile(targetPath, ts.sys.fileExists, "tsconfig.json") ||
ts.findConfigFile(targetPath, ts.sys.fileExists, "jsconfig.json");
Expand Down
14 changes: 5 additions & 9 deletions internal/codeguard/checks/support/typescript_semantic_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func TestTypeScriptRuntimeDiscoveryHonorsExplicitRuntime(t *testing.T) {
}
}

func TestTypeScriptSemanticRunnerIntersectsCorpusWithConfiguredFiles(t *testing.T) {
func TestTypeScriptSemanticRunnerUsesCorpusDespiteConfiguredFiles(t *testing.T) {
if _, err := exec.LookPath("node"); err != nil {
t.Skip("node is required for the embedded semantic runner test")
}
Expand Down Expand Up @@ -73,21 +73,17 @@ module.exports = {
TargetPath: root,
SourceFiles: []string{
filepath.Join(root, "src/app.ts"),
filepath.Join(root, "vendor/excluded.ts"),
filepath.Join(root, "node_modules/pkg/index.ts"),
filepath.Join(root, "src/tsconfig-excluded.ts"),
},
}
_, err := runTypeScriptSemanticRunner(context.Background(), input)
if err == nil {
t.Fatal("semantic runner succeeded; want fake compiler root report")
}
message := err.Error()
if !strings.Contains(message, filepath.Join(root, "src/app.ts")) {
t.Fatalf("configured corpus root missing from compiler roots: %s", message)
}
for _, excluded := range []string{"vendor/excluded.ts", "node_modules/pkg/index.ts"} {
if strings.Contains(message, excluded) {
t.Fatalf("tsconfig-excluded corpus file %q reached compiler roots: %s", excluded, message)
for _, sourceFile := range input.SourceFiles {
if !strings.Contains(message, sourceFile) {
t.Fatalf("corpus root %q missing from compiler roots: %s", sourceFile, message)
}
}
}
Expand Down
Loading