fix(ci): validate Homebrew formula version - #135
Merged
alxxjohn merged 1 commit intoAug 19, 2026
Conversation
alxxjohn
deleted the
alexj/investigate-vulnerability-in-homebrew-validation.yml
branch
August 19, 2026 01:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
internal/version/version.govalue directly into a double-quoted Ruby Homebrew formula string, which allowed PR-controlled interpolation (e.g.#{...}) to be evaluated when Homebrew loaded the formula.var Numberdeclarations which made untrusted PR content reach the Ruby sink; this change prevents unsafe values from being written into the formula.Description
.github/workflows/homebrew-validation.ymlso the version extracted byscripts/version-from-source.shmust match a standard semver pattern before the formula file is generated.Testing
go test ./...and test packages passed.ruby -e 'require "yaml"; YAML.load_file(".github/workflows/homebrew-validation.yml", aliases: true)'which succeeded.bash scripts/version-from-source.shyields0.1.0and that the new regex accepts it, and that a malicious payload like#{system 'id'}is rejected by the validation.git diff --checkand YAML/format checks to ensure the change is well-formed.Codex Task