fix(security): include targeted node_modules files in TypeScript semantic scans - #137
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
node_modules, which caused fail-level security rules (e.g.security.typescript.insecure-tls) to be silently omitted when the semantic runtime is available.node_modulesunder that target) to avoid a scanner false negative that the file-walking fallback would otherwise have caught.Description
node_modulesexclusion from the semantic analyzability predicate by updatingisAnalyzableSourceFileininternal/codeguard/checks/support/typescript_semantic_runner_core.jsso files are accepted if they are non-declaration script files with a recognized extension and areisWithinTarget.isNodeModulesPathhelper function frominternal/codeguard/checks/support/typescript_semantic_runner_core.js.TestSecuritySemanticAnalyzerScansNodeModulesWithinTargetintests/checks/typescript_semantic_test.gothat places a file undernode_modulesinside a target and asserts the semantic analyzer reports thesecurity.typescript.insecure-tlsfinding.Testing
go test ./tests/checks -run 'TestSecurity(SemanticAnalyzerScansNodeModulesWithinTarget|CheckUsesSemanticTypeScriptAnalyzerForRequirePropertyAlias)$' -count=1, and the tests passed.go test ./internal/codeguard/checks/support ./internal/codeguard/checks/security, and thesupportpackage tests passed whilesecuritycontained no test files to run.Codex Task