fix: resolve structural mutation ownership from scopes - #172
Merged
Conversation
added 19 commits
August 29, 2026 19:31
alxxjohn
added a commit
that referenced
this pull request
Aug 30, 2026
🤖 I have created a release *beep* *boop* --- ## [1.8.3](v1.8.2...v1.8.3) (2026-08-30) ### Bug Fixes * avoid conversion shape shadow ([4d23d58](4d23d58)) * bound TypeScript captures to lexical scope ([cb4f157](cb4f157)) * close C++ scope and namespace gaps ([abdb752](abdb752)) * close structural acceptance parser gaps ([202c57f](202c57f)) * close structural evidence compatibility gaps ([7a5210a](7a5210a)) * close structural origin review findings ([9cfe717](9cfe717)) * harden C++ structural ownership resolution ([5fb8c7d](5fb8c7d)) * harden Go structural ownership state ([2f2c286](2f2c286)) * merge Go field semantics and fallthrough state ([ea8fa30](ea8fa30)) * preserve Go conversion ownership ([cbaa5e9](cbaa5e9)) * refine structural effect grammar ([7c759d2](7c759d2)) * resolve C++ structural mutation ownership ([84f1265](84f1265)) * resolve Go structural mutation ownership ([085af1a](085af1a)) * resolve indexed Go conversions ([394689b](394689b)) * resolve structural mutation ownership from scopes ([#172](#172)) ([cdac600](cdac600)) * stabilize structural finding identity ([14fe1d4](14fe1d4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DbRow::integerPrecision coverage
auto,constexpr, constructors, member initializers, references, pointers, moves, templates, lambdas, namespace-qualified owners, and compact assignmentsVerification
go test ./...— 27/27 packages passedgo vet ./...— passed0 issuescrumb-app acceptance note
The read-only repaired scan reports 302 unsuppressed findings: 121 Go and 181 C++. It also reports 5,401 suppressed findings and unresolved diagnostics for both languages. Three genuine caller-owned Go findings were restored during final review.
The requested full-scan threshold of at most 19 cannot be evaluated as written against the supplied crumb-app revision/profile. A pre-repair control on the same checkout has 193 non-structural unsuppressed findings before structural findings are counted; 19 is the
smell.message-chaincount, not the full scan total. Baseline control reports 887 stale entries, while detector precision repairs necessarily change active/stale matching; the final read-only audit reports 5,267 active and 1,293 stale entries. No crumb files, suppressions, or baseline entries were modified.