chore: remove unused test bindings - #357
Open
dormouse-bot wants to merge 1 commit into
Open
Conversation
Deploying mouseterm with
|
| Latest commit: |
05faedb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://11a29ea8.mouseterm.pages.dev |
| Branch Preview URL: | https://chore-remove-unused-test-bin.mouseterm.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly survey turned up two unused bindings in test files. Both are pure dead-code removals with no behavioral change.
lib/src/components/wall/AgentBrowserPanel.test.tsx— dropped the unusedtype WallActionsimport. The file usesWallActionsContextand thestubActionshelper, but never references theWallActionstype directly.server-lib-common/test/security-guarantees.test.mjs— dropped the unusedserverbinding from theevery connection requires fresh user presencetest's destructure. That test drives everything throughclient.buildConnectRequest(...),host.handleConnect(...), andhost.issueChallenge();serverappeared only in a comment.No regression test — there's no behavior to guard, only unused symbols removed. Verified the affected suites still pass locally:
AgentBrowserPanel.test.tsx(22 passed) andsecurity-guarantees.test.mjs(10 passed).