refactor: QML GUI stack [Part 3] -> Categorical NodeRegistry - #2607
Merged
RobBuchananCompPhys merged 3 commits intoSep 22, 2026
Merged
RobBuchananCompPhys merged 3 commits into
RobBuchananCompPhys merged 3 commits into
Conversation
RobBuchananCompPhys
changed the title
NodeRegistryNodeRegistry
RobBuchananCompPhys
added this pull request to stack #2609
September 15, 2026 07:38
RobBuchananCompPhys
force-pushed
the
dissolve2/gui2-stack/part-3-node-registry-refactor-categories
branch
from
September 16, 2026 13:02
579c402 to
932089a
Compare
trisyoungs
approved these changes
Sep 18, 2026
trisyoungs
left a comment
trisyoungs
left a comment
Member
There was a problem hiding this comment.
This looks great to me. Nice catches on the various incorrect Node::type entries!
rprospero
approved these changes
Sep 21, 2026
rprospero
left a comment
rprospero
left a comment
Contributor
There was a problem hiding this comment.
I like the new registry, though I've added a suggestion to simplify the code.
RobBuchananCompPhys
force-pushed
the
dissolve2/gui2-stack/part-3-node-registry-refactor-categories
branch
from
September 21, 2026 15:00
932089a to
7dc5f9d
Compare
Base automatically changed from
dissolve2/gui2-stack/part-2-qml-dev-phase1
to
develop2
September 22, 2026 09:20
RobBuchananCompPhys
force-pushed
the
dissolve2/gui2-stack/part-3-node-registry-refactor-categories
branch
from
September 22, 2026 09:20
8a3a45f to
d8fb8d6
Compare
RobBuchananCompPhys
deleted the
dissolve2/gui2-stack/part-3-node-registry-refactor-categories
branch
September 22, 2026 10:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.