refactor: QML GUI stack [Part 4] -> More UI components - #2608
RobBuchananCompPhys wants to merge 16 commits into
Conversation
RobBuchananCompPhys
changed the title
0f8e871 to
ba177d5
Compare
ba177d5 to
dd75cac
Compare
trisyoungs
left a comment
trisyoungs
left a comment
There was a problem hiding this comment.
Some minor comments and suggestions. I haven't performed a live test of the code at this point - that will be my job for next week!
There was a problem hiding this comment.
Just a general comment here. Another issue I have been thinking about is how we handle forcefields in the new UI. I am tempted at this point to have each forcefield represented by a Node of its own, so there is no need for a central list / store of the available Forcefield objects. This means that there can be less strict adherence to using the Forcefield class to implement a forcefield, which sounds odd to say, but one special type of forcefield we definitely need is one which takes the current molecule geometry (bonds, angles at least) and applies some sensible force constants to it. This doesn't fit well in within the Forcefield class, but it could be implemented however we like if we just have a Node for it.
125b544 to
4483928
Compare
85cc63f to
18618e9
Compare
This branch has not been deployed
3 participants
No description provided.