Conversation
Not for merging. Deleted once the run confirms every runner goes red.
Owner
Author
|
Verified: the failing test made every runner red, including Windows, which previously reported success for a failing step. The exit-code propagation fix is on main in 2e6c6cd. Closing unmerged and deleting the branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary. Adds a test that asserts a falsehood, to confirm that a red test run now fails the job on Linux, macOS and Windows — the Windows runner previously reported success for a failing step because pwsh did not propagate the exit code.
Closing and deleting the branch as soon as the run is red.