feat: add MCHD command - #274
Open
ax0 wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the MCHD command, which opens the door to chords for MIDI instruments. In addition, muting and unmuting of MIDI channels now works: Muting immediately cuts off the last note and discards all MIDI notes and commands until the channel is unmuted.
Type of change
Resolves Channel mutes does nothing on MIDI instruments #104
Partially resolves ARPG does nothing on MIDI instruments #103
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
MCHD aabbcommand on a MIDI instrument with various values ofaaandbb. Note that the notesaaandbbsemitones above the last played note (modulo 128) are played. These notes should last as long as the 'root note'.Test Configuration:
See above.
Checklist:
sources/Application/Model/Project.h