chore(deps): take four majors, fix the aes-gcm and typescript blockers - #42
Merged
Merged
Conversation
Closes out six of the seven majors Dependabot surfaced once the open-pull-requests-limit backlog drained. Merged as-is (#38, #40, #36, #35): - sqlx 0.8.6 -> 0.9.0 - sha2 0.10.9 -> 0.11.0 - marked 17.0.6 -> 18.0.12 - jsdom 28.1.0 -> 30.1.1 #39 aes-gcm 0.10.3 -> 0.11.1 was red only on a deprecation, under `clippy -D warnings`: `Array::from_slice` is deprecated in favour of TryFrom. Two call sites in recovery_email_service.rs. The encrypt side takes a [u8; 12] so it uses `Nonce::from`; the decrypt side takes a decoded Vec, so `Nonce::try_from` now enforces the 12-byte length that an explicit `len() != 12` check used to cover -- same error message, one less branch. #37 typescript 5.9.3 -> 7.0.2 stays closed: svelte-check 4.7.6 peers `typescript@^5.0.0 || ^6.0.0`, so it cannot resolve. The real bug was in dependabot.yml -- the svelte-toolchain group's own comment says "svelte-check pins svelte + typescript", but `typescript` was never in its patterns, which is why this opened as a solo PR. Added. jsdom needed more than a version bump. #35 is green only because its lockfile happens to pin 30.0.1; the `^30.0.1` range means the next install drifts to 30.1.x, where `URL.createObjectURL(file)` throws `Cannot read properties of undefined (reading '_buffer')` and the avatar preview in ProfileSettingsView silently never renders. Stubbed createObjectURL/revokeObjectURL in src/test/setup.ts so the suite no longer depends on jsdom's blob-URL internals. Worth noting the test that caught it asserted `getByRole('img', { name: 'Avatar preview' })`, which passes either way: the {:else} fallback div carries the same role and aria-label. Only the "Remove selected image" button assertion actually proves the preview rendered. Verified: server fmt, clippy -D warnings, 401 tests, cargo audit clean. Client lint, check (0 errors), 294 tests, build, npm audit clean. #41 (webrtc 0.17 -> 0.20) is left open -- its API de-async'd and needs a real migration in the voice path. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Sep 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes out six of the seven majors Dependabot surfaced once the
open-pull-requests-limitbacklog drained. Replaces #35, #36, #38, #39 and #40, and explains why #37 stays closed.Taken as-is
sqlxsha2markedjsdom#39 aes-gcm 0.11 — was red on a deprecation, not a break
Array::from_sliceis deprecated in favour ofTryFrom, andclippy -D warningsturns that into a failure. Two call sites inrecovery_email_service.rs:[u8; 12], so it usesNonce::fromVec<u8>, soNonce::try_fromnow enforces the 12-byte length that an explicitlen() != 12check used to cover — same error message, one less branch#37 typescript 7.0.2 — stays closed, but it exposed a config bug
svelte-check@4.7.6peerstypescript@^5.0.0 || ^6.0.0, so TS 7 cannot resolve andnpm ciERESOLVEs. The real defect was independabot.yml: thesvelte-toolchaingroup's own comment says "svelte-check pins svelte + typescript", buttypescriptwas never in itspatterns. That omission is why this opened as a solo PR instead of moving in lockstep. Added it, so typescript can only move alongside a svelte-check that accepts it. (TS 6 satisfies the peer range, so this isn't permanently stuck.)jsdom needed more than a bump
#35 is green only because its lockfile happens to pin 30.0.1. The declared range is
^30.0.1, so the nextnpm installdrifts to 30.1.x — where this happens:With that throwing,
previewUrlstays null and the avatar preview inProfileSettingsViewsilently never renders. Merging #35 as-is would have planted a failure that appears on an unrelated future install.Fixed by stubbing
createObjectURL/revokeObjectURLinsrc/test/setup.ts— the component only needs a string forimg.src, so the suite no longer depends on jsdom's blob-URL internals either way.One thing worth a look while you're here: the test that caught this asserts
which passes whether or not the preview rendered — the
{:else}fallback<div>carries the samerole="img"andaria-label="Avatar preview". Only the subsequent "Remove selected image" button assertion actually proves anything. Not changed here, but that assertion is weaker than it looks.Verification
cargo fmt --check,cargo clippy -- -D warnings, 401 tests,cargo auditall cleannpm run lint,npm run check(0 errors / 274 files), 294 tests,npm run build,npm auditall cleanLeft open
#41 webrtc 0.17 → 0.20. Three 0.x majors at once and the API de-async'd (
Result<usize, Error> is not a futureatvoice_channel.rs:93and:97). That's a real migration in the least test-covered part of the codebase, and it deserves its own change rather than riding along in a dependency sweep.🤖 Generated with Claude Code