Say when a query is not understood, and let a pattern keep its escapes and commas - #44
Merged
Merged
Conversation
…s and commas
Package F of the stability report, the query language.
- An escape inside a pattern now reaches it. The scanner records which
characters came through a backslash, and the pattern is compiled with
them put back, so name:/a\?/ no longer matches every entry and
path:/C:\\Windows/ no longer matches none.
- A comma inside a pattern that has not closed belongs to it. One rule
splits a member into values, read by the parser and by the chip cut:
name:/^w{2,}/ works and name:/a/,/b/ is still two patterns.
- Turning a chip off takes one value out of a comma list rather than the
whole member. The scanner records where each character stood, so the
rest of the line stays as it was typed.
- A value that opens with / and never closes is a mistake with a sentence
saying how to close it, or how to search for the slash. The last member
being typed in the window is passed over. An empty // is a mistake too.
- A pasted path (C:\..., C:/...) is a search, not a field called C. No
field or alias has a one-letter name, and a test holds that.
- Two one-sided bounds on the same number or size narrow instead of being
folded into either. Exact values, ranges and the comma are unchanged.
- ? finds a field that was refused or never read, and none and any are
unsure about such a field instead of a confident no.
- QueryParser.SyntaxVersion goes from 2 to 3.
- QuerySizes moves to its own file, and the depth ratchet goes down by one.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Package F of the stability report: the query language says when it does not understand, and a pattern keeps its escapes and commas.
What changes for somebody using the tool
Measured on a machine with about 800 entries, before the change in brackets:
name:/a\?/a?matches everythingpath:/C:\\Windows/\Wbecame a character classname:/^w{2,}/pid:>1000 pid:<2000C:\Windows\System32\svchost.exename://name:/abc\/status:running,stoppedleavesstatus:runninginstead of an empty box.?finds a field that was refused or never read.noneandanycount such an entry among the unsure ones instead of a confident no.pid:<100,>60000asks for both ends outside a range.Contract
The meaning of three existing spellings changes (escapes in a pattern, two bounds on a number,
?withnoneandanyon a field without an answer), soQueryParser.SyntaxVersiongoes from 2 to 3.QueryProblemKindgainsUnclosedPatternat the end. README, the query language page (both languages) andCHANGELOG.mdsay it.Checked
🤖 Generated with Claude Code