Skip to content

refactor(core-web): remove dead libs/dotcms and libs/dot-layout-grid (#36950) - #37150

Queued
nicobytes wants to merge 8 commits into
mainfrom
nicobytes/36950-remove-dead-core-web-libs-impl
Queued

refactor(core-web): remove dead libs/dotcms and libs/dot-layout-grid (#36950)#37150
nicobytes wants to merge 8 commits into
mainfrom
nicobytes/36950-remove-dead-core-web-libs-impl

Conversation

@nicobytes

@nicobytes nicobytes commented Aug 20, 2026

Copy link
Copy Markdown
Member

PR 2 of 2 — the implementation

Spec approved in #37147 (PR 1, spec only). This PR carries the actual removal.

Closes #36950

What was removed

Deleted Files What it was
core-web/libs/dotcms/ 43 Legacy initDotCMS JS SDK (npm dotcms@0.0.21), superseded by @dotcms/client
core-web/libs/dot-layout-grid/ 20 Vendored angular2-grid (NgGrid) directives, superseded by GridStack in libs/template-builder

Plus the seven references that pointed at them, across five files:

File Removed
core-web/tsconfig.base.json @dotcms/dotcms and @dotcms/dot-layout-grid path aliases
core-web/nx.json libs/dotcms/**/* from the @nx/jest/plugin include glob
core-web/package.json build:docs:dotcms — already broken, its libs/dotcms/typedoc.json does not exist
core-web/README.MD both project-table rows
.claude/triage-config.json stale core-web/libs/dot-layout-grid triage area

The last two were not in the issue's AC list — they are dangling references it missed.

Verification

Both stories ran a genuine Red → Green gate (assertions confirmed failing before the deletion, passing after).

Check Result
Nx project list 57 → 55; exactly the two targets removed, nothing else changed, nothing added
nx run-many -t build --exclude=tag:skip:build (the CI command, core-web/pom.xml:196) ✅ 17 projects + 1 dep, green in 49.8s
nx graph ✅ resolves — proves the tsconfig.base.json paths block is still coherent
JSON validity: tsconfig.base.json, nx.json, package.json, triage-config.json ✅ all four parse
Dangling references repo-wide ✅ none (excluding specs/, which documents the paths)
pnpm-lock.yaml ✅ byte-identical — same blob hash a4975568…, no workspace entry existed
Projects with a test target ✅ 49, all jest-plugin entries intact — the nx.json glob edit cost no surviving project its test target
Live siblings untouched ✅ 4 @dotcms/dotcms-* aliases, build:docs:dotcms-models, and the generic '@dotcms/**' eslint pattern all still present

Three of the issue's ACs were already satisfied before this work

No action taken on these; recorded for the reviewer:

  1. npm deprecate dotcms — already done. The registry reports deprecated = 'Please use @dotcms/client'. Deleting monorepo source does not unpublish the package, and it stays installable (~439 downloads/month).
  2. Close [03/44] Enable TS strict mode in dotcms #35936 / [04/44] Enable TS strict mode in dot-layout-grid #35937 — already CLOSED.
  3. Rescope epic strict mode: Enable TypeScript strict mode across the core-web workspace #35932 (44 → 42) — already reflected in the epic body, which cites Remove dead core-web libraries (libs/dotcms, libs/dot-layout-grid) #36950 for both removals.

ADR alignment

Consulted dotCMS/platform-adrs via the mandatory before_plan hook.

  • ADR-0013 (skip integration/Postman/Karate for frontend-only merge-queue changes) — applies. Six of seven edits are under core-web/**; the seventh (.claude/triage-config.json) matches no filter in .github/filters.yaml, and since dorny/paths-filter uses OR logic it sets no flag rather than flipping backend true. So this stays a frontend-only PR and the core-web build is the meaningful gate.
  • ADR-0019 (date-lockstep SDK versioning) — directionally supportive. libs/dotcms is a pre-lockstep legacy SDK outside libs/sdk/**; removing it and its unused publish target moves toward that ADR's end state.
  • No conflicts. No new ADR proposed — the superseding decisions were already made elsewhere.

Note for the reviewer

Two verification commands in spec.md were corrected after PR 1 was approved. No acceptance criterion changed — command form only:

  1. nx show projects emits a single-line JSON array when stdout is not a TTY, so the original | grep '^dotcms$' assertion could never match. Now --json | jq -r '.[]'.
  2. Applied Copilot's grep -E portability fix (BRE \| → ERE |).

Say the word if you'd rather these were split out rather than folded in.

plan.md, tasks.md, and checklists/ are absent by design — .gitignore lines 229-233 deliberately ignore specs/*/plan.md, specs/*/tasks.md, and specs/*/checklists/.

🤖 Generated with Claude Code

nicobytes and others added 2 commits August 20, 2026 17:12
@nicobytes @claude
docs(speckit): spec for removing dead core-web libs (#36950)
0d9d1b2 
PR 1 of the Spec-Kit two-PR flow: the issue-resolution spec only, no
implementation.

Scopes the removal of two dead Nx libraries from `core-web`:

- `libs/dotcms` (43 files) — legacy `initDotCMS` SDK, superseded by
  `@dotcms/client`. Tagged skip:build/lint/test so CI never compiled it;
  does not compile today (`TS2307` on a `'dotcms-models'` import alias
  that no longer exists). Last functional commit 2022-10-05.
- `libs/dot-layout-grid` (20 files) — vendored `angular2-grid` NgGrid
  directives, superseded by GridStack in `libs/template-builder`. Last
  consumer deleted in 5e75d4d (2024-08-22); does not compile today
  (`ComponentFactoryResolver` no longer exported by @angular/core 22).

Both were verified to have zero consumers repo-wide — by path alias, by
every exported symbol, and (for the directive library) by template
selector, since directives are consumable from HTML without a TS import.

The spec also records three of the issue's acceptance criteria as already
satisfied (npm deprecation of `dotcms`, closing #35936/#35937, rescoping
epic #35932 to 42 projects) and adds two dangling references the issue
missed: a broken `build:docs:dotcms` typedoc script and a stale triage
area entry.

Per Principle V, the spec states explicitly that no new test is added and
why — deleting zero-consumer code has no behavior to assert — and defines
an executable Red/Green removal assertion plus the existing
`nx affected -t build,lint,test` regression gate in its place.

Refs: #36950
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@nicobytes @claude
refactor(core-web): remove dead libs/dotcms and libs/dot-layout-grid (#…
bae8983 
…36950)

Both Nx libraries had zero consumers, were excluded from every CI gate,
and did not compile against Angular 22.

- libs/dotcms (43 files) — legacy initDotCMS SDK (npm dotcms@0.0.21),
  superseded by @dotcms/client. Tagged skip:build/lint/test, so
  `nx run-many -t build --exclude=tag:skip:build` (core-web/pom.xml:196)
  never compiled it. Three files imported from 'dotcms-models', an alias
  that no longer exists, so it failed with TS2307 regardless of strict
  mode. Last functional commit 2022-10-05.
- libs/dot-layout-grid (20 files) — vendored angular2-grid NgGrid
  directives, superseded by GridStack in libs/template-builder. Had no
  build target at all. NgGrid.ts imported ComponentFactoryResolver,
  which @angular/core 22 no longer exports. Last consumer deleted in
  5e75d4d (2024-08-22); never published to npm.

Zero consumers was verified by path alias, by every exported symbol, and
— for the directive library, which templates can use by selector without
a TS import — by searching [ngGrid], [ngGridItem] and ng-grid-placeholder
across .html/.vtl/.jsp/.ts/.js.

Also removes two dangling references the issue did not list:
- core-web/package.json build:docs:dotcms, already broken because
  libs/dotcms/typedoc.json does not exist
- .claude/triage-config.json stale dot-layout-grid triage area

No test is added: this deletes code with zero call sites, so there is no
behavior to assert (Constitution Principle V declared exception). The
gate is instead an executable removal assertion plus the existing suite.

Verified: Nx projects 57 -> 55 with exactly these two removed and nothing
else changed; build (17 projects), lint (46) and test (42) all green;
nx graph resolves, so the tsconfig paths block is intact; pnpm-lock.yaml
byte-identical; the four @dotcms/dotcms-* sibling aliases,
build:docs:dotcms-models and the generic '@dotcms/**' eslint pattern
untouched.

npm dotcms@0.0.21 stays published — it is already deprecated in favor of
@dotcms/client, and removing monorepo source does not unpublish it.

Also corrects two verification commands in spec.md post-approval (form
only, no AC change): `nx show projects` emits single-line JSON when piped,
so the assertion needs `--json | jq -r '.[]'`; and BRE `\|` -> ERE `|`.

Closes: #36950
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings August 20, 2026 22:25
@github-actions github-actions Bot mentioned this pull request Aug 20, 2026
Open
13 tasks
@github-actions github-actions Bot added the Area : Frontend PR changes Angular/TypeScript frontend code label Aug 20, 2026
@claude

claude Bot commented Aug 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Claude finished @nicobytes's task in 32s —— View job

SDK Compatibility Analysis

  • Read docs/core/SDK_BREAKING_CHANGE_CATEGORIES.md
  • Get full PR diff (88af0bad55...366f828467)
  • Analyze diff against every breaking-change category
  • Post verdict

Verdict: No SDK breaking change detected.

Analysis

The diff (71 files, +262/-4999) touches only:

  • core-web/libs/dotcms/** (deleted) — the legacy standalone dotcms@0.0.21 npm SDK, unrelated to and superseded by @dotcms/client. Not under core-web/libs/sdk/**.
  • core-web/libs/dot-layout-grid/** (deleted) — vendored angular2-grid Angular directives used by the legacy template builder UI, superseded by GridStack. Admin-UI-only, not SDK-consumed.
  • Config/plumbing: core-web/tsconfig.base.json, core-web/nx.json, core-web/package.json, core-web/README.MD, .claude/triage-config.json, .github/workflows/publish_docs.yml, .specify/feature.json, specs/36950-remove-dead-core-web-libs/spec.md.

None of these touch any of the surfaces the reference doc flags:

  • No changes under core-web/libs/sdk/client/** (page-api.ts, buildPageQuery/buildQuery) — no GraphQL schema/query changes (G-1, G-2, G-3).
  • No changes to /api/v1/nav, /api/v1/content, or /api/v1/page/* response shapes on the Java side (R-1).
  • No changes to core-web/libs/sdk/uve/src/internal/events.ts or __DOTCMS_UVE_EVENT__ message names (U-1).
  • No changes to DotCMSUVEAction in core-web/libs/sdk/types/src/lib/editor/public.ts (U-2).
  • No changes to SdkVersionWebInterceptor, X-DotCMS-Version/X-DotCMS-Min-SDK headers, or compareVersions()/parseVersionSegments() in sdk-compatibility.ts (H-1).

This is a pure dead-code removal (unused legacy JS SDK + unused vendored grid library) plus cleanup of dangling references in config/docs/CI files — no wire-format, GraphQL schema, REST shape, postMessage protocol, or version-handshake code is touched. Per the custom instructions, no PR comment or label is posted since this is not a breaking change.

Copilot AI reviewed Aug 20, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes two unused/dead Nx libraries from the core-web workspace (libs/dotcms legacy JS SDK and libs/dot-layout-grid legacy Angular grid directives) and cleans up the remaining workspace references so the Nx graph/paths/scripts/docs no longer mention them.

Changes:

  • Deleted core-web/libs/dotcms/ and core-web/libs/dot-layout-grid/ source trees.
  • Removed TypeScript path aliases and Nx/Jest plugin include entries that referenced those libs.
  • Removed stale docs/triage/documentation references (README rows, broken docs script, triage area entry).

Reviewed changes

Copilot reviewed 69 out of 69 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
specs/36950-remove-dead-core-web-libs/spec.md Spec/verification record accompanying the deletion work.
core-web/tsconfig.base.json Removes @dotcms/dotcms and @dotcms/dot-layout-grid path aliases.
core-web/README.MD Removes library rows for the deleted projects from the workspace table.
core-web/package.json Removes broken build:docs:dotcms script entry.
core-web/nx.json Removes libs/dotcms/**/* from Jest plugin include globs.
.claude/triage-config.json Removes stale core-web/libs/dot-layout-grid triage area.
core-web/libs/dotcms/tsconfig.spec.json Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/tsconfig.lib.json Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/tsconfig.json Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/utils/request.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/utils/getEsQuery.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/utils/DotCMSHttpClient.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/index.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSSite.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSPageFormat.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSPage.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSNavigation.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSLanguage.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSHttpClient.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSForm.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSEvent.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSError.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSElasticSearch.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSContent.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSConfiguration.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/models/DotCMSAuthorization.model.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiWidget.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiWidget.spec.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiSite.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiPage.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiPage.spec.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiNavigation.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiLanguage.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiForm.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiForm.spec.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiEvent.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiElasticSearch.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiContentType.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiContentType.spec.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiContent.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiContent.spec.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiConfiguration.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/lib/api/DotApiAuthorization.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/src/index.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/README.md Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/project.json Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/package.json Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/jest.config.ts Deleted (part of removing libs/dotcms).
core-web/libs/dotcms/eslint.config.mjs Deleted (part of removing libs/dotcms).
core-web/libs/dot-layout-grid/tsconfig.spec.json Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/tsconfig.lib.json Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/tsconfig.json Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/src/test.ts Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/src/public_api.ts Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/src/lib/NgGrid.css Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/src/lib/NgGrid_FixSmall.css Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/src/lib/modules/NgGrid.module.ts Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/src/lib/interfaces/INgGrid.ts Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/src/lib/helpers/NgGridHelper.ts Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/src/lib/directives/NgGridItem.ts Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/src/lib/directives/NgGrid.ts Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/src/lib/components/NgGridPlaceholder.ts Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/README.md Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/project.json Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/package.json Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/ng-package.prod.json Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/ng-package.json Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/karma.conf.js Deleted (part of removing libs/dot-layout-grid).
core-web/libs/dot-layout-grid/eslint.config.mjs Deleted (part of removing libs/dot-layout-grid).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread core-web/package.json
@nicobytes
chore(speckit): add feature directory pointer for core-web libs removal
82387e3 
Registers the speckit feature tracking file so tooling can locate the
spec directory for the dead core-web libs cleanup work.
@nicobytes @claude
fix(cicd): drop deleted build:docs:dotcms from publish_docs workflow (#…
9df2078 
…36950)

Review catch on #37150: this PR removed the `build:docs:dotcms` script
from core-web/package.json, but .github/workflows/publish_docs.yml still
invoked it — an eighth dangling reference to libs/dotcms that the original
sweep missed, because that sweep matched library paths rather than the
npm script name.

Keeps `build:docs:dotcms-models`, whose library is still live.

Two corrections to the review's framing, for the record:

- The workflow is `disabled_manually` in GitHub Actions and has no run
  history, so it would not have failed on the next push to main. The
  reference was stale, not actively breaking.
- `build:docs:dotcms-models` is broken too: no typedoc.json exists
  anywhere in the repo (both were deleted around #23122/#23257), so the
  whole "Run NX Commands" step cannot succeed even after this fix. That
  is pre-existing and unrelated to libs/dotcms, so it is left alone here;
  the workflow looks like a candidate for outright deletion in a
  follow-up — it also pins Node 16.13.2 and runs `npm install` in a pnpm
  workspace.

publish_docs.yml matches neither `.github/workflows/cicd_comp_*.yml` nor
`cicd_1-pr.yml`, so it does not match the `backend` path filter and this
PR stays frontend-only for merge-queue purposes (ADR-0013).

Refs: #36950
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@nicobytes
nicobytes requested a review from a team as a code owner August 21, 2026 01:36
@nicobytes

nicobytes commented Aug 21, 2026

Copy link
Copy Markdown
Member Author

Review feedback addressed — 9df2078

Both reviewers flagged the same single issue, and it was real: .github/workflows/publish_docs.yml still invoked build:docs:dotcms after this PR deleted that script. Fixed by dropping that line.

Root cause of the miss: my reference sweep matched library paths (libs/dotcms/, @dotcms/dotcms) but never the npm script name, so a reference that named only the script slipped through. That was the eighth dangling reference, on top of the seven in the original scope.

Two corrections to the reported severity

The workflow would not have failed on the next push to main. "Publish Docs" is disabled_manually in GitHub Actions (id 27375464), with no run history — gh run list --workflow=publish_docs.yml is empty. Stale reference, not an imminent break.

build:docs:dotcms-models — the line both reviews said to keep — is broken too. No typedoc.json exists anywhere in the repo:

$ find . -name typedoc.json -not -path "*/node_modules/*"
(no results)

Both configs disappeared around #23122 / #23257. So the Run NX Commands step still cannot succeed after this fix; I removed only the reference to the library this PR deletes.

Scope decision

I deliberately did not fix build:docs:dotcms-models or delete the workflow. dotcms-models is a live library and its missing typedoc config is pre-existing and unrelated to #36950 — fixing it here would be scope creep into someone else's problem.

publish_docs.yml does look like a genuine follow-up candidate for deletion: it's disabled, both build commands are broken, it pins Node 16.13.2, and it runs npm install in a pnpm workspace. Say the word and I'll open that issue.

Re-verified after the fix

  • No exact build:docs:dotcms reference remains anywhere (only the -models variants, which are intentional)
  • publish_docs.yml still parses as valid YAML; all five steps intact
  • publish_docs.yml matches neither .github/workflows/cicd_comp_*.yml nor cicd_1-pr.yml, so it misses the backend path filter — this PR stays frontend-only for the merge queue, preserving ADR-0013 alignment
  • The 63 deletions and 5 config edits are unchanged; build/lint/test were green before this commit and it touches only a disabled workflow file

@github-actions github-actions Bot added the Area : CI/CD PR changes GitHub Actions/workflows label Aug 21, 2026
@nicobytes nicobytes mentioned this pull request Aug 24, 2026
Merged
@nicobytes

nicobytes commented Aug 24, 2026

Copy link
Copy Markdown
Member Author

Re: the failing QA Stuck Check — PR validate job

That failure is not caused by this PR — it's a pre-existing time bomb on main. Fix opened separately as #37169.

Why it runs here at all

The validate workflow triggers on changes to .github/scripts/qa-stuck-check/**, its two workflow files, or .claude/triage-config.json — which this PR edits to drop the stale dot-layout-grid triage area. That path is rarely touched, which is why nobody had hit the failure yet.

Why it fails

test-find-stuck-issues.js pins the clock with Date.now = () => FIXED_NOW (Monday 2026-05-25), but find-stuck-issues.js:73 reads it as new Date() — which doesn't consult Date.now(). The fixtures were frozen while the script kept using the real clock, so once the real date drifted past FIXED_NOW, every fixture aged past STUCK_DAYS=3. The fixture deliberately named "Too fresh" (1 day old, Team : Maintenance) was measured at 66 business days, so it got grouped as stuck and assert.ok(!byTeam['Team : Maintenance']) failed.

Verified pre-existing — it reproduces on a clean checkout of main:

git checkout main
node .github/scripts/qa-stuck-check/test-find-stuck-issues.js   # fails

#37169 freezes the whole Date constructor rather than just Date.now(), so the pin the test already intended actually reaches the code under test. Test file only, no production changes.

This PR's own gates were green: nx run-many -t build --exclude=tag:skip:build (17 projects), lint (46) and test (42) all passed.

Minor: stray file in this PR

.specify/feature.json is included via 82387e3828. It's local Spec-Kit session state ({"feature_directory":"specs/36950-remove-dead-core-web-libs"}), not part of the removal, and isn't on main today. Worth dropping unless it was committed on purpose — note .gitignore already excludes specs/*/plan.md, specs/*/tasks.md and specs/*/checklists/, so this pointer is the one Spec-Kit working artifact that isn't ignored.

@nicobytes
nicobytes enabled auto-merge August 24, 2026 15:58
@nicobytes
nicobytes added this pull request to the merge queue Aug 24, 2026
Any commits made after this event will not be merged.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@oidacra oidacra oidacra approved these changes
@zJaaal zJaaal zJaaal approved these changes

Assignees

No one assigned

Labels

AI: Safe To Rollback Area : CI/CD PR changes GitHub Actions/workflows Area : Frontend PR changes Angular/TypeScript frontend code

Projects

dotCMS - Product Planning
Status: No status

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove dead core-web libraries (libs/dotcms, libs/dot-layout-grid) [03/44] Enable TS strict mode in dotcms

4 participants

@nicobytes @oidacra @zJaaal