Skip to content

chore(cicd): remove QA-stuck check automation - #37173

Open
nollymar wants to merge 1 commit into
mainfrom
issue-35826-remove-qa-stuck-check
Open

chore(cicd): remove QA-stuck check automation#37173
nollymar wants to merge 1 commit into
mainfrom
issue-35826-remove-qa-stuck-check

Conversation

@nollymar

@nollymar nollymar commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary

Removes the QA-stuck check automation added in #35802 (issue #35826), including the follow-up fix merged in #37169.

What's removed

File Purpose
.github/workflows/cicd_scheduled_qa-stuck-check.yml Scheduled job that posted stuck-in-QA reminders to team Slack channels
.github/workflows/cicd_pr_qa-stuck-check-validate.yml PR validation for the script above
.github/scripts/qa-stuck-check/find-stuck-issues.js ProjectV2 query + team grouping logic
.github/scripts/qa-stuck-check/test-find-stuck-issues.js Local smoke test (this is the file #37169 patched)

913 lines deleted; the now-empty .github/scripts/qa-stuck-check/ directory goes with them.

What's intentionally kept

The slack_channel entries in .claude/triage-config.json are left in place. Although #35802 introduced them, they are useful beyond this automation, so they are not reverted here.

Notes

  • No remaining references to qa-stuck or find-stuck-issues anywhere in the repo (.github, docs, .claude).
  • cicd_pr_qa-stuck-check-validate.yml is not a required status check on main (only Initialize / Initialize and Finalize / Final Status are), so removing it does not affect branch protection or the merge queue.
  • Relates to Automate QA-stuck issue reminder via scheduled Slack notifications #35826 (already closed) — this PR reverses that automation rather than reopening it.

🤖 Generated with Claude Code

This PR fixes: #35826

Deletes the scheduled QA-stuck workflow, its PR validation workflow, and
the supporting finder/smoke-test scripts. The slack_channel entries in
.claude/triage-config.json are retained for other consumers.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@claude

claude Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Claude finished @nollymar's task in 34s —— View job


Code Review

  • Analyze the diff (4 files deleted, 913 lines)
  • Verify no dangling references to the removed automation
  • Confirm intentionally-kept config is present
  • Confirm removal doesn't affect branch protection / merge queue

Verification

Claim Result
No qa-stuck / find-stuck-issues references in repo ✅ Confirmed — repo-wide grep returns nothing (the two .github "stuck" hits are unrelated: a "Workflow Stuck in Queue" doc heading and a deploy-script comment)
.github/scripts/qa-stuck-check/ directory gone ✅ Confirmed — directory no longer exists
slack_channel entries kept in .claude/triage-config.json ✅ Confirmed — 4 entries still present
Validate workflow not a required check Not independently verifiable from the diff — branch protection rules live in repo settings, not the tree. Trusting the PR description here.

New Issues

No issues found.

This is a clean, self-contained removal. All four deleted files belong to a single feature (the QA-stuck-check automation), the deletions leave no dangling references (workflow triggers, uses: references, docs, or .claude config), and the empty parent directory is removed with them. Keeping the slack_channel entries is a reasonable call since they predate/outlive this automation.

· issue-35826-remove-qa-stuck-check

@github-actions github-actions Bot added the Area : CI/CD PR changes GitHub Actions/workflows label Aug 24, 2026

@oidacra oidacra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the removal is clean and complete:

  • No remaining references to qa-stuck or find-stuck-issues anywhere in the repo — the only hits are the four files this PR deletes.
  • .github/scripts/qa-stuck-check/ holds exactly those two .js files, so the directory is fully emptied.
  • CI_MACHINE_TOKEN and SLACK_BOT_TOKEN remain in use across other workflows, so no secrets are orphaned.
  • The #37169 follow-up fix is included (it patched the smoke-test file removed here).
  • Initialize / Initialize and Finalize / Final Status both pass, confirming the removed validate workflow was not a blocking check.

Well-scoped deletion. Approving.

@oidacra

oidacra commented Aug 24, 2026

Copy link
Copy Markdown
Member

Not a line changed by this PR — this is about .claude/triage-config.json, which the description lists under "What's intentionally kept".

I went looking for what still reads that file once this merges, and couldn't find anything:

  • On this branch, a repo-wide search for triage-config returns no hits at all. The only four files that referenced it are the ones deleted here.
  • The area labeler uses its own config, .github/area-labels.yml (sparse-checkout + readFileSync), not this file.
  • issue_on-open_add-to-triage-project..yml uses the TRIAGE_PROJECT_TOKEN secret and the TRIAGE_PROJECT_NUMBER variable, not this config.
  • Nothing consumes routing_rules, teams[].areas, or teams[].members either — so it's the whole file left without a reader, not just the slack_channel entries.

The description says the slack_channel entries are useful beyond this automation. Is that use something outside the repo — a Claude skill or agent reading it at runtime, given it sits under .claude/ — or was another consumer planned? Asking mainly to get it on the record: with no checked-in reader, that file is easy to lose track of and drift out of date as teams and channels change.

Not blocking the approval either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area : CI/CD PR changes GitHub Actions/workflows

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

Automate QA-stuck issue reminder via scheduled Slack notifications

2 participants