[Mono] Fix JLO lookup for packaged MAUI satellite assemblies - #12496
Open
jonathanpeppers wants to merge 5 commits into
Open
[Mono] Fix JLO lookup for packaged MAUI satellite assemblies#12496jonathanpeppers wants to merge 5 commits into
jonathanpeppers wants to merge 5 commits into
Conversation
Add a Release MAUI template build that uses Mono to detect regressions such as #12487. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 82531bd4-3cc7-485a-8150-57fa0ebe4d04
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an additional MAUI template build in the Azure Pipelines automation to exercise the Mono runtime path in Release configuration, intended to catch regressions related to Mono packaging (per #12487) earlier in CI.
Changes:
- Add a new “Build MAUI template - Mono” step that runs the MAUI template project in Release with
UseMonoRuntime=true. - Mirror the new step across the primary, public, and internal pipeline YAML definitions.
- Capture a dedicated binlog (
MauiTestProj-Mono.binlog) for troubleshooting Mono-template build failures.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| build-tools/automation/azure-pipelines.yaml | Adds a Mono-based MAUI template Release build step to the main pipeline’s MAUI integration stage. |
| build-tools/automation/azure-pipelines-public.yaml | Adds the same Mono MAUI template build step to the public pipeline. |
| build-tools/automation/azure-pipelines-internal.yaml | Adds the same Mono MAUI template build step to the internal pipeline. |
Preserve generated scan-marker metadata for unchanged framework assemblies after trimming so Mono builds do not look for JLO sidecars in NuGet packages. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 82531bd4-3cc7-485a-8150-57fa0ebe4d04
jonathanpeppers
changed the title
Create the intermediate ABI directories before touching scan markers for unchanged assemblies after trimming. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 82531bd4-3cc7-485a-8150-57fa0ebe4d04
Use the shared scan marker for unprocessed resource assemblies so JLO and typemap consumers do not probe NuGet package directories. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 82531bd4-3cc7-485a-8150-57fa0ebe4d04
Do not advertise scan markers for trimmed satellite assemblies in the trimmable typemap path, where no marker producer runs. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 82531bd4-3cc7-485a-8150-57fa0ebe4d04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
The new MAUI Mono CI build reproduces the expected missing
Microsoft.Maui.Controls.resources.jlo.xmlfailure from the package cache before this fix.Fixes #12487.