Skip to content

[build] Recommend latest supported JDK in workload metadata #12500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Redth wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

[build] Recommend latest supported JDK in workload metadata #12500

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions tools/workload-dependencies/Program.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,7 @@ JProperty CreateJdkProperty (XDocument doc)
var v = new Version (JdkVersion ?? "17.0");
var start = new Version (v.Major, v.Minor);
var end = GetMaxJdkVersion (v);
var latestRevision = JdkVersion ?? GetLatestRevision (doc, "jdk");
var latestRevision = GetLatestRevision (doc, "jdk", start, new Version (end));
var contents = new JObject (
new JProperty ("version", $"[{start},{end})"));
if (!string.IsNullOrEmpty (latestRevision))
Expand Down Expand Up @@ -202,9 +202,13 @@ IEnumerable<XElement> GetSupportedElements (XDocument doc, string element)
.OrderByRevision ();
}

string? GetLatestRevision (XDocument doc, string element)
string? GetLatestRevision (XDocument doc, string element, Version minimumVersion, Version maximumVersion)
{
return GetByRevisions (doc, element)
.Where (item => {
var version = new Version (item.Revision);
Comment thread
Redth marked this conversation as resolved.

@github-actions github-actions Bot Aug 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 ❌ Error handling — OrderByRevision() accepts one-component revisions by appending .0, but this new new Version (item.Revision) parses the original raw value. A supported feed entry such as revision="21" will now throw and abort metadata generation. Preserve the normalized Version in GetByRevisions() and compare that here; please add regression coverage for this accepted input.

Rule: Preserve existing input normalization

@jonathanpeppers jonathanpeppers Aug 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this it just saying new Version("21") will throw ArgumentException and to check how it's done in other methods in this file.

return version >= minimumVersion && version < maximumVersion;
})
.LastOrDefault ()
.Revision;
}
Expand Down
Loading