[aw] Enable local diff checks in Android PR Reviewer - #12502
Merged
Conversation
Co-authored-by: jonathanpeppers <840039+jonathanpeppers@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix missing tools reported in Android PR Reviewer
[aw] Enable local diff checks in Android PR Reviewer
Aug 25, 2026
jonathanpeppers
marked this pull request as ready for review
August 25, 2026 17:12
jonathanpeppers
approved these changes
Aug 25, 2026
jonathanpeppers
added
the
ready-to-review
jonathanpeppers
enabled auto-merge (squash)
August 25, 2026 17:12
Contributor
There was a problem hiding this comment.
Pull request overview
Enables the Android PR Reviewer agentic workflow to run local git diff commands by adding git diff to the workflow firewall/tool allowlist and regenerating the compiled lock workflow so the permission is reflected at runtime.
Changes:
- Add
git diff *to thetools.bashallowlist in.github/workflows/android-reviewer.md. - Regenerate
.github/workflows/android-reviewer.lock.ymlso the job invocation includes--allow-tool 'shell(git diff)'.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/android-reviewer.md | Allows the reviewer agent to execute local git diff for cross-checking PR changes. |
| .github/workflows/android-reviewer.lock.yml | Updates the generated workflow to include the corresponding shell(git diff) permission. |
rolfbjarne
approved these changes
Aug 25, 2026
jonathanpeppers
disabled auto-merge
August 25, 2026 20:15
simonrozsival
approved these changes
Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Android PR Reviewer could not cross-check PR changes with local
git diffbecause the command was excluded from its security allowlist.git diffwith arbitrary diff arguments while keeping other Git commands blocked.- git diff *android-reviewer.lock.ymlwith the correspondingshell(git diff)permission.