Skip to content

[tests] Use approved feed for analyzer references #12520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathanpeppers merged 4 commits into from
Aug 25, 2026
Merged

[tests] Use approved feed for analyzer references #12520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
12e451d
[tests] Use approved feed for analyzer references
jonathanpeppers Aug 25, 2026
82fd88e
[tests] Always copy analyzer NuGet config
jonathanpeppers Aug 25, 2026
51ca8d2
[tests] Preserve incremental analyzer config copy
jonathanpeppers Aug 25, 2026
4b113d7
[tests] Use standard incremental config copy
jonathanpeppers Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Microsoft.Android.Sdk.Analysis/Tests/Microsoft.Android.Sdk.Analysis.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@
</ItemGroup>
<ItemGroup>
<ProjectReference Include="..\Microsoft.Android.Sdk.Analysis.csproj" />
<None Include="$(MSBuildThisFileDirectory)..\..\..\NuGet.config" Link="NuGet.config">
<CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
</None>
</ItemGroup>
<Import Project="..\..\..\build-tools\scripts\NUnitReferences.projitems" />
<ItemGroup>
Expand Down
2 changes: 2 additions & 0 deletions src/Microsoft.Android.Sdk.Analysis/Tests/Verifiers/CSharpAnalyzerVerifier`1+Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ public class Test : CSharpAnalyzerTest<TAnalyzer, DefaultVerifier>
public List<DiagnosticAnalyzer> Analyzers => analyzers;
public Test ()
{
ReferenceAssemblies = CSharpVerifierHelper.DefaultReferenceAssemblies;

SolutionTransforms.Add ((solution, projectId) => {
var project = solution.GetProject (projectId);
var compilationOptions = project.CompilationOptions;
Expand Down
3 changes: 2 additions & 1 deletion src/Microsoft.Android.Sdk.Analysis/Tests/Verifiers/CSharpCodeFixVerifier`2+Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ public class Test : CSharpCodeFixTest<TAnalyzer, TCodeFix, DefaultVerifier>
{
public Test ()
{
ReferenceAssemblies = CSharpVerifierHelper.DefaultReferenceAssemblies;

SolutionTransforms.Add ((solution, projectId) => {
var compilationOptions = solution.GetProject (projectId).CompilationOptions;
compilationOptions = compilationOptions.WithSpecificDiagnosticOptions (
Expand All @@ -22,4 +24,3 @@ public Test ()
}
}
}

2 changes: 2 additions & 0 deletions src/Microsoft.Android.Sdk.Analysis/Tests/Verifiers/CSharpCodeRefactoringVerifier`1+Test.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@ public class Test : CSharpCodeRefactoringTest<TCodeRefactoring, DefaultVerifier>
{
public Test ()
{
ReferenceAssemblies = CSharpVerifierHelper.DefaultReferenceAssemblies;

SolutionTransforms.Add ((solution, projectId) => {
var compilationOptions = solution.GetProject (projectId).CompilationOptions;
compilationOptions = compilationOptions.WithSpecificDiagnosticOptions (
Expand Down
5 changes: 5 additions & 0 deletions src/Microsoft.Android.Sdk.Analysis/Tests/Verifiers/CSharpVerifierHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,15 @@
using Microsoft.CodeAnalysis;
using Microsoft.CodeAnalysis.CSharp;
using Microsoft.CodeAnalysis.Testing;
using System;
using System.Collections.Immutable;
using System.IO;

internal static class CSharpVerifierHelper
{
internal static ReferenceAssemblies DefaultReferenceAssemblies { get; } =
ReferenceAssemblies.Default.WithNuGetConfigFilePath (Path.Combine (AppContext.BaseDirectory, "NuGet.config"));

/// <summary>
/// By default, the compiler reports diagnostics for nullable reference types at
/// <see cref="DiagnosticSeverity.Warning"/>, and the analyzer test framework defaults to only validating
Expand Down
Loading