Share diagnostics release tool across repositories - #5988
Open
hoyosjs wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR refactors the repo’s release-preparation tooling so it can be packaged and reused across repositories, while expanding processing to include both shipping and non-shipping drop assets and adding pipeline-driven filtering (e.g., skipping specific files during release preparation).
Changes:
- Package
DiagnosticsReleaseToolas a .NET tool (Microsoft.Diagnostics.ReleaseTool) and wire it into the repo build. - Extend drop acquisition and release processing to include non-shipping assets, and propagate a “public vs internal-only” designation via
IsAssetForPublicRelease. - Move repo-specific constants into
tool-list.jsonand add skip-file support (used to skipMergedManifest.xmlin pipelines).
File summaries
| File | Description |
|---|---|
| eng/release/tool-list.json | Adds ReleaseToolConstants to centralize repo-specific release constants. |
| eng/release/Scripts/AcquireBuild.ps1 | Adds -IncludeNonShipping and passes --non-shipping to darc gather-drop. |
| eng/release/DiagnosticsReleaseTool/README.md | Updates docs to describe shipping + non-shipping processing and public-release marking. |
| eng/release/DiagnosticsReleaseTool/DiagnosticsRepoHelpers.cs | Loads constants from tool manifest and uses them for bundle identification/metadata. |
| eng/release/DiagnosticsReleaseTool/DiagnosticsReleaseTool.csproj | Enables packing as a .NET tool (Microsoft.Diagnostics.ReleaseTool) and includes README/3rd-party notices. |
| eng/release/DiagnosticsReleaseTool/DiagnosticsReleaseRunner.cs | Uses manifest-driven helpers, processes shipping + non-shipping roots, adds shouldSkipFile, and improves logging config base path. |
| eng/release/DiagnosticsReleaseTool/DiagnosticsReleaseCommandLine.cs | Adds --skip-files option and threads it into configuration. |
| eng/release/DiagnosticsReleaseTool/DiagnosticsManifestGenerator.cs | Adds IsAssetForPublicRelease into manifest sections and decouples bundled-tools category naming. |
| eng/release/DiagnosticsReleaseTool/DarcHelpers.cs | Returns both shipping and derived non-shipping directories from the darc drop. |
| eng/release/DiagnosticsReleaseTool/Core/Release.cs | Extends release processing to handle public + internal-only roots and supports file skipping. |
| eng/release/DiagnosticsReleaseTool/Core/FileReleaseData.cs | Adds IsAssetForPublicRelease to file-release records. |
| eng/release/DiagnosticsReleaseTool/Config.cs | Stores skip-file list as a case-insensitive FrozenSet. |
| eng/pipelines/prepare-release.yml | Enables non-shipping acquisition and forwards skip-file list into the tool invocation. |
| diagnostics.yml | Supplies default skipFileList: MergedManifest.xml to the prepare-release pipeline. |
| build.proj | Adds the release tool project to the repo build graph. |
Review details
- Files reviewed: 15/15 changed files
- Comments generated: 6
- Review effort level: Lite
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation