Restore querySelectorAll from the method that was saved for it - #195
Merged
Conversation
This was referenced Sep 5, 2026
jdalton
force-pushed
the
fix/uninstall-restore
branch
from
September 6, 2026 02:30
d93be15 to
42a3357
Compare
jdalton
force-pushed
the
fix/uninstall-restore
branch
from
September 6, 2026 04:42
42a3357 to
9b4fa4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Restore Element and HTMLElement querySelectorAll from the saved collection method when uninstalling.
Tests
The regression runs two install/uninstall cycles. It checks method identity, NodeList results, ordered element identity, empty results, and the separate querySelector contract. The complete local Docker CI workflow passes, including package checks, Node tests, WPT on both builds, and coverage thresholds.