Stop :autofill matching every element - #196
Merged
Merged
Conversation
This was referenced Sep 5, 2026
jdalton
force-pushed
the
fix/autofill-nop
branch
from
September 6, 2026 02:30
e97a760 to
d5af60f
Compare
jdalton
force-pushed
the
fix/autofill-nop
branch
from
September 6, 2026 04:51
d5af60f to
d837e18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Route :autofill and :-webkit-autofill through the guarded host matcher from merged #178. Ordinary elements no longer match automatically, and the compiler continues validating the rest of the selector. Genuine autofill state stays live; unsupported or delegating hosts fall back safely.
Tests
Focused regressions cover both aliases, empty results, matching and selection, changing host state, selector suffixes, unsupported native selectors, and bounded recursion. Tests use direct ESM default imports from the generated CommonJS module.
The full local Docker CI workflow passes on current master, including Node, Chromium, both WPT builds, package compatibility, and unchanged coverage thresholds.