Establish shared legacy runtime initialization - #197
Merged
Conversation
jdalton
force-pushed
the
refactor/legacy-runtime-init
branch
from
September 5, 2026 15:10
cc1d5d9 to
058c3e2
Compare
jdalton
changed the title
jdalton
force-pushed
the
refactor/legacy-runtime-init
branch
from
September 5, 2026 15:14
058c3e2 to
bf9f225
Compare
jdalton
changed the title
jdalton
force-pushed
the
refactor/legacy-runtime-init
branch
from
September 5, 2026 15:18
bf9f225 to
c545320
Compare
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give #178 and #167 shared runtime initialization that we can extend as more capabilities need legacy handling. Modern mode uses native implementations; legacy mode checks support once and reuses the native implementation or fallback.
createWeakMap()is the first helper: legacy mode still uses a native map when available and returnsundefinedotherwise.Validation:
node --test test/legacy-runtime.test.cjspasses all 4 tests, including reuse without repeated detection. Both dependent revisions are tested and ready to publish after this merges.