Review media and time state handling extracted from #167 - #202
Open
jdalton wants to merge 1 commit into
Open
Conversation
jdalton
marked this pull request as ready for review
September 5, 2026 19:42
jdalton
force-pushed
the
preserve/media-time-pseudos
branch
from
September 6, 2026 02:30
08be56c to
7daac5c
Compare
jdalton
force-pushed
the
preserve/media-time-pseudos
branch
from
September 6, 2026 11:40
7daac5c to
e6769cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tooling update
Rebased onto merged #212 as one commit. Sources and tests use
.mts, Node tests use Vitest, and the published JavaScript paths stay unchanged. The original engine changes are preserved.Local lint, formatting, Node and packed-package checks pass, with the documented expected failures retained. All 41 WPT pages pass against both generated builds.
Change
Preserve the remaining media/time changes and all state-pseudo tests from #167 in a focused PR. This is not production-ready.
The archived buffering/stalled approximation contradicts the specification: those states must also match :playing. Two expected-failure regressions expose the conflict. Playback, timed stalls, volume locks, and host timelines need review before merge. See test/media-time-review.md for the remaining work and draft specification links.
Validation: six preserved Chromium tests and one Node regression pass; two expected media-state failures fail as documented. The browser fixture runs locally without WPT setup. These tests do not certify media-state semantics. Display-state changes remain with #178.