Skip to content

Add shared Playwright test dependency - #210

Closed
jdalton wants to merge 1 commit into
dperini:masterfrom
jdalton:chore/shared-test-dependencies
Closed

Add shared Playwright test dependency#210
jdalton wants to merge 1 commit into
dperini:masterfrom
jdalton:chore/shared-test-dependencies

Conversation

@jdalton

@jdalton jdalton commented Sep 5, 2026

Copy link
Copy Markdown
Collaborator

Add @playwright/test 1.62.1 as a shared development dependency. This is one commit adding one line to package.json.

Merged #211 already supplies jsdom 30.0.1 and the selector adapter. #178 now uses that adapter for the original reentry test, so no jsdom 26 alias is needed. Reference tests keep jsdom's default engine.

The 15 inherited Node tests pass. After this merges, dependent PRs can drop their repeated Playwright dependency additions. The refreshed #167 owns the lockfile and broader tooling.

@jdalton
jdalton force-pushed the chore/shared-test-dependencies branch from 0ad72fa to edef440 Compare September 5, 2026 23:16
@jdalton
jdalton force-pushed the chore/shared-test-dependencies branch from edef440 to 69f0d3e Compare September 5, 2026 23:58
@jdalton jdalton changed the title Add shared selector test dependencies Add shared Playwright test dependency Sep 5, 2026
@jdalton

jdalton commented Sep 6, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by merged #167 and #212. Master already contains the pinned Playwright dependency, lockfiles, and shared test tooling, so this PR has no remaining change to preserve. The dependent PRs have been updated onto #212 with .mts sources and tests.

@jdalton jdalton closed this Sep 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant