feat(chat): carry the bubble width a wired message asks for - #212
Draft
SimoLeoLife wants to merge 2 commits into
Draft
feat(chat): carry the bubble width a wired message asks for#212SimoLeoLife wants to merge 2 commits into
SimoLeoLife wants to merge 2 commits into
Conversation
The official client reads an optional int at the very end of the chat packet: the bubble width the message wants, -1 when the room setting should rule. The parser now reads it the same way, guarded by bytesAvailable so an emulator that does not send it changes nothing, and the session chat event hands it to whoever draws the bubble.
The parser test still imported @nitrots/utils, which this branch renamed to @octane/utils; the test file could not resolve it in CI.
SimoLeoLife
marked this pull request as draft
September 6, 2026 20:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The official client (AIR 13) reads an optional int at the very end of the chat packet: the bubble width a wired message asks for,
-1when the room setting should rule, otherwise0wide,1normal,2thin, the same valuesRoomChatSettingsalready uses.RoomUnitChatParserreads it guarded bybytesAvailable, so an emulator that does not send it changes nothing;flush()resets it to-1.RoomSessionChatEventcarries it as a new trailing constructor parameter (default-1), andRoomChatHandlerpasses it through for talk, shout and whisper.RoomUnitChatParser.test.tspins the three cases: no tail, a tail, and the reset between packets.The chat packets are already
exemptionsinprotocol/packet-field-contracts.json, so the manifest is unchanged (verify-packet-contract-manifest.mjs --emulator ../emulatorestill reports 658 verified / 183 unpaired / 360 exempt). Full suite: 398 tests green,vite buildgreen.Companion changes: Polaris-Emulator
fix/wired-updates(the four messaging boxes carry the width andRoomChatMessageserialises it) and Octanefix/wired-updates(the picker in the wired windows and the bubble that honours it).