SDSTOR-25689: using sisl common headers in homestore v8 - #915
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
The public README still directs consumers to the deleted HomeStore coroutine helper API.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Migrates HomeStore v8 to SISL-provided coroutine helpers and bounded queues.
Changes:
- Replaces local helpers with
sisl::asyncandsisl::BoundedMPMCQueue. - Removes duplicate local headers.
- Bumps HomeStore to 8.3.0 and SISL to 14.9.
File summaries
| File | Description |
|---|---|
conanfile.py |
Updates package and SISL versions. |
src/lib/blkalloc/blk_cache_queue.cpp |
Uses SISL bounded queue. |
src/lib/blkalloc/blk_cache_queue.h |
Updates queue type and include. |
src/lib/blkalloc/bounded_mpmc_queue.hpp |
Removes local queue implementation. |
src/lib/blkalloc/fixed_blk_allocator.h |
Uses SISL bounded queue. |
src/lib/checkpoint/cp_mgr.cpp |
Migrates coroutine helpers. |
src/lib/common/coro_helpers.hpp |
Removes local coroutine helpers. |
src/lib/device/journal_vdev.cpp |
Migrates detached CP invocation. |
src/lib/homestore.cpp |
Migrates synchronous coroutine waits. |
src/lib/index/index_service.cpp |
Migrates detached CP invocation. |
src/lib/index/wb_cache.cpp |
Migrates asynchronous continuations. |
src/lib/logstore/log_dev.cpp |
Migrates await and synchronization helpers. |
src/lib/replication/log_store/home_raft_log_store.cpp |
Migrates log-store helpers. |
src/lib/replication/log_store/repl_log_store.cpp |
Migrates synchronous waiting. |
src/lib/replication/repl_dev/raft_repl_dev.cpp |
Migrates replication coroutine helpers. |
src/lib/replication/repl_dev/raft_state_machine.cpp |
Migrates checkpoint waits. |
src/lib/replication/repl_dev/solo_repl_dev.cpp |
Migrates asynchronous continuations. |
src/lib/replication/service/generic_repl_svc.cpp |
Migrates synchronous waiting. |
src/lib/replication/service/raft_repl_service.cpp |
Migrates membership-operation waits. |
src/tests/test_append_blkalloc.cpp |
Updates detached test tasks. |
src/tests/test_common/homestore_test_common.hpp |
Migrates shared test helpers. |
src/tests/test_common/hs_repl_test_common.hpp |
Migrates replication test waits. |
src/tests/test_common/raft_repl_test_base.hpp |
Migrates replication test helpers. |
src/tests/test_cp_mgr.cpp |
Migrates checkpoint test helpers. |
src/tests/test_data_service.cpp |
Migrates asynchronous test operations. |
src/tests/test_index_crash_recovery.cpp |
Migrates index destruction waits. |
src/tests/test_log_dev.cpp |
Migrates log-device continuations. |
src/tests/test_log_store.cpp |
Migrates log-store continuation. |
src/tests/test_log_store_long_run.cpp |
Migrates long-run continuation. |
src/tests/test_raft_repl_dev_dynamic.cpp |
Migrates member replacement wait. |
src/tests/test_solo_repl_dev.cpp |
Migrates solo replication helpers. |
Review details
- Files reviewed: 31/31 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
JacksonYao287
force-pushed
the
using-sisl-header
branch
from
September 16, 2026 06:11
3540635 to
5281c5f
Compare
JacksonYao287
force-pushed
the
using-sisl-header
branch
3 times, most recently
from
September 16, 2026 06:31
b13a107 to
152aede
Compare
JacksonYao287
force-pushed
the
using-sisl-header
branch
from
September 16, 2026 06:44
152aede to
a6c5489
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/v8.x #915 +/- ##
===========================================
Coverage ? 46.05%
===========================================
Files ? 111
Lines ? 12471
Branches ? 5876
===========================================
Hits ? 5744
Misses ? 3178
Partials ? 3549 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
shosseinimotlagh
approved these changes
Sep 16, 2026
Member
Author
|
thanks @shosseinimotlagh for the review, I will merge it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
since we have migrated som common part to sisl(coro.hpp), we use the lastest to replace the duplicated code in homestore.
all the changes in this PR are all cosmetic format change, no logic change is made