Skip to content

fix(vue-components): handle string form validation errors - #881

Merged
MakhBeth merged 1 commit into
mainfrom
fix/omega-form-general-string-errors
Sep 10, 2026
Merged

fix(vue-components): handle string form validation errors#881
MakhBeth merged 1 commit into
mainfrom
fix/omega-form-general-string-errors

Conversation

@MakhBeth

@MakhBeth MakhBeth commented Sep 10, 2026

Copy link
Copy Markdown
Contributor

Form-level TanStack validators can return strings, but OmegaForm.Errors treated every error as a map of schema issue arrays. A password mismatch returned from onSubmit therefore crashed with e.filter is not a function instead of displaying the validation message.

Accept unknown error values, display strings directly, and check object/array/message shapes before extracting schema messages. Includes a patch changeset and regression coverage for submit errors clearing after correction and mixed schema/string/unsupported values.

Validation: targeted regression tests passed (2 tests). The pre-push ship gate passed: pnpm check, pnpm lint, and pnpm test.

@MakhBeth
MakhBeth marked this pull request as ready for review September 10, 2026 18:04
@pkg-pr-new

pkg-pr-new Bot commented Sep 10, 2026

Copy link
Copy Markdown

Open in StackBlitz

@effect-app/cli

npm i https://pkg.pr.new/effect-app/libs/@effect-app/cli@881

effect-app

npm i https://pkg.pr.new/effect-app/libs/effect-app@881

@effect-app/eslint-codegen-model

npm i https://pkg.pr.new/effect-app/libs/@effect-app/eslint-codegen-model@881

@effect-app/eslint-shared-config

npm i https://pkg.pr.new/effect-app/libs/@effect-app/eslint-shared-config@881

@effect-app/infra

npm i https://pkg.pr.new/effect-app/libs/@effect-app/infra@881

@effect-app/vue

npm i https://pkg.pr.new/effect-app/libs/@effect-app/vue@881

@effect-app/vue-components

npm i https://pkg.pr.new/effect-app/libs/@effect-app/vue-components@881

commit: fa0e80c

@MakhBeth
MakhBeth merged commit 2476064 into main Sep 10, 2026
6 checks passed
@MakhBeth
MakhBeth deleted the fix/omega-form-general-string-errors branch September 10, 2026 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant