fix(vue-components): handle string form validation errors - #881
Merged
Conversation
MakhBeth
marked this pull request as ready for review
September 10, 2026 18:04
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Form-level TanStack validators can return strings, but OmegaForm.Errors treated every error as a map of schema issue arrays. A password mismatch returned from onSubmit therefore crashed with
e.filter is not a functioninstead of displaying the validation message.Accept unknown error values, display strings directly, and check object/array/message shapes before extracting schema messages. Includes a patch changeset and regression coverage for submit errors clearing after correction and mixed schema/string/unsupported values.
Validation: targeted regression tests passed (2 tests). The pre-push ship gate passed:
pnpm check,pnpm lint, andpnpm test.