fix(vue-components): resolve indexed inputs and deduplicate array errors - #883
Merged
Conversation
MakhBeth
marked this pull request as ready for review
September 10, 2026 21:53
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Indexed inputs such as
rows[13].textnow resolve schema metadata and render outsideform.Array. Registered array fields appear once inform.Errors, with their field label, instead of also appearing as unregistered dotted paths.Move array-index stripping into OmegaInput and remove OmegaArray's redundant metadata provider. Preserve the injection used by OmegaTaggedUnion for active-branch metadata.
Normalize bracket indices to dotted paths when registering, looking up, and unregistering field labels.
Add regressions for indices 0 and 13, field errors and labels, unmount cleanup, and inputs inside form.Array. Include a patch changeset.
Add Storybook
OmegaForm / Indexed Table: sortable and paginated v-data-table cells use source indices outside form.Array, with Row 14 initially invalid and an inspectable form-values view.Validation: 9 targeted tests passed across IndexedInputErrors and TaggedUnionBehavior. Focused Vue typecheck of the OmegaForm stories passed. The full package Vue typecheck reports an unrelated error in
stories/FixedNuxtErrorBoundary/Demo.vue:40(TS2345:{}is not assignable tonever). The pre-push ship gate passed:pnpm check,pnpm lint, andpnpm test.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.