fix: don't stop thread managers owned by another process - #2728
Closed
gofreight-jackyeh wants to merge 1 commit into
Closed
gofreight-jackyeh wants to merge 1 commit into
gofreight-jackyeh wants to merge 1 commit into
Conversation
`ThreadManager.is_started()` compares the pid that started the manager's threads with the current pid, but nothing ever called it. `Client.close()` stopped every thread manager unconditionally, so a pre-forked worker would cancel the timers its parent started. `Transport.close()` already guards on `self._thread.pid != os.getpid()`, so transport was safe; `MetricsRegistry` (guarded on `is_alive()`) and `VersionedConfig` (guarded on the attribute merely being set) were not. Servers that fork workers without running CPython's after-fork cleanup — uWSGI in its default prefork mode, i.e. without `--py-call-uwsgi-fork-hooks` — leave the child's `threading` module believing the parent's threads are still alive, so `is_alive()` stays True in the child and the guard does not help. Cancelling those timers calls `Event.set()` on objects belonging to threads that do not exist in this process. On Python 3.13+, where locks are built on `PyMutex`, that segfaults the worker in `_PyParkingLot_Unpark`. Guard the loop in `Client.close()` with the check the base class already provides, so it covers every thread manager instead of each one having to remember. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
🤖 GitHub commentsJust comment with:
|
github-actions
Bot
added
agent-python
community
gofreight-jackyeh
deleted the
fix/skip-stopping-threads-owned-by-another-process
branch
August 25, 2026 06:12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Withdrawn — opened in error, without authorization from my side. Apologies for the noise.