Conversation
Co-authored-by: xrmx <12932+xrmx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CI failure in test_instrument_nonexisting_method on Windows
Stabilize missing-method instrumentation test across runtimes
Sep 11, 2026
xrmx
approved these changes
Sep 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Windows Python 3.9 failure came from a brittle test assertion in
tests/instrumentation/base_tests.py: it expected runtime-generatedAttributeErrortext that varies across Python/wrapt/platform combinations. This change updates the test to assert the stable agent-generated log message for skipped instrumentation instead.Problem
test_instrument_nonexisting_methodasserted on"has no attribute", which is not a stable contract of the agent and differs on Windows/Python 3.9.Change
AbstractInstrumentedModule.instrument()when a target method cannot be resolved.elasticapm.instrument.Effect
logging.Logger.non_existing_method— without depending on platform-specific exception wording.Fixes #2733