Racecar consumer instrumentation improvements - #1429
Conversation
|
@elasticmachine run elasticsearch-ci/docs |
|
I don't think the tests failures had anything to do with the changes. |
|
@ErvalhouS thank you for the contribution. No, the build failures are not related to your change. I'm trying to fix the build in a different PR and once that's done, I'll rebase this branch to bring in the changes. Thank you! |
07eadd5 to
ca160ef
Compare
|
@picandocodigo can we trigger a re-run on CI? |
ca160ef to
6f2a0b1
Compare
|
Any news on this? |
|
@copilot resolve the merge conflicts in this pull request |
1 similar comment
|
@copilot resolve the merge conflicts in this pull request |
|
Please merge latest and fix conflicts so we can review and merge. |
|
Merged latest There was a single conflict: Verified locally on the merge commit:
Two bits of self-review context for whoever picks this up, both intentionally left as-is:
|
What does this pull request do?
This PR adds better context to Racecar consumer transactions.
ConsumerClass#methodWhy is it important?
Right now there's only the
process.argsto differ transactions happening in different consumers, which could be problematic since it isn't the default visualization grouping from other libraries. Error handling is also not recorded, what makes transactions be stored with an unknown status.Checklist
.rubocop.yml)I have made corresponding changes to the documentationI have updated supported-technologies.asciidocAdded an API method or config option? Document in which version this will be introducedRelated issues
Relates #1284