Add an additive feature-flag skill for agents - #3989
Draft
reakaleek wants to merge 1 commit into
Draft
Conversation
Flag-off must keep the previous default so new flags do not hide shipped behavior. Co-Authored-By: Cursor Grok 4.6 <noreply@anthropic.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/3989/ Sample changed pages: |
Mpdreamz
approved these changes
Sep 1, 2026
Mpdreamz
left a comment
Mpdreamz
left a comment
Member
There was a problem hiding this comment.
Worth having. Fwiw navigation_preview was tested on and off by me and and agent so sometimes things can still slip :)
Unless we test all feature flag combinations with synthetics but that is a bit expensive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Agents that add a feature flag now load
/feature-flagand must prove the flag-off path still matches the previous default.Affects: Agentic Skills
Why
A new feature flag is easy to wire around new code only. Existing output then lives only on the flag-on path. Environments that leave the flag off lose behavior that already shipped. The additivity check has to happen before the work is done, not after a regression.
What
Additive rule
Flag off keeps the previous default. Flag on adds new behavior only. The skill treats a relocated copy of shipped output as a failure, not as a new feature.
Flag registration
The skill points at
FeatureFlags.cs,feature_flagsinassembler.yml, andToFeatureFlags(). New flags stay off inprod. Tests must cover flag-off, flag-on, sibling flags, and the default environment.Agent discovery
AGENTS.mdlists/feature-flagwith the other required skills so an agent loads it when it adds or extends a flag.Out of scope This PR does not change how flags load or which environments enable them.
Made with Cursor