Drop should-comment-success / should-comment-failure outputs from evaluate-artifact - #3995
Open
Mpdreamz wants to merge 2 commits into
Open
Drop should-comment-success / should-comment-failure outputs from evaluate-artifact#3995Mpdreamz wants to merge 2 commits into
Mpdreamz wants to merge 2 commits into
Conversation
…luate-artifact submit/apply no longer reads these outputs — PR 3 (docs-actions#324) removed the three actions/github-script steps that gated on them and replaced them with changelog github-comment running in the downstream release-notes-comments workflow. Removing them here completes the four-PR migration sequence. Co-Authored-By: Claude <noreply@anthropic.com>
Docs preview (local build)Handbook preview: https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/3995/ |
The CommentBody private record had no [JsonPropertyName] annotation, so source-generated JSON emitted "Body" (PascalCase). GitHub's issues/comments API requires lowercase "body" and returns 422 for an unrecognised key, treating the payload as body-less. Co-Authored-By: Claude <noreply@anthropic.com>
theletterf
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the two step outputs
should-comment-successandshould-comment-failurefromChangelogArtifactEvaluationServicenow thatchangelog/submit/apply(docs-actions #324) no longer reads them.Affects: Automation
Why
evaluate-artifactemitted two comment-gate outputs thatsubmit/applyused to decide which JS comment script to run. Those three comment steps were replaced by the nativechangelog github-commentcommand in docs-actions #324, which reads thechangelog-decisionartifact directly — the outputs are now dead. Leaving them in place would mislead future readers into thinking something still consumes them.What
Outputs removed from
ChangelogArtifactEvaluationServiceshouldCommentSuccessandshouldCommentFailurevariables and their twoSetOutputAsynccalls are deleted. The surrounding log message is trimmed to remove the two fields. No other logic in the service changes;should-commitand all other outputs are unaffected.Tests updated
Four test methods in
ChangelogArtifactEvaluationServiceTestshad assertions verifying the removed outputs. Each assertion is dropped and the method is renamed to reflect only what it still tests (SetsCommitFalseinstead ofSetsCommentSuccessFlag, etc.).Verify
dotnet test tests/Elastic.Changelog.Tests/Stack: 4 of 4, on top of docs-actions #324.
Risk: This PR must not merge before docs-actions #324. Removing the outputs while
submit/applystill gates on them (if: steps.meta.outputs.should-comment-success == 'true') would silently prevent the comment steps from firing — elastic/cloud would lose PR comments with no visible error. Merge order is: docs-actions #324 first (or confirm it is already merged and thev1tag updated), then this PR.Out of scope: Renaming
evaluate-artifact/prepare-artifactand their service types — that is its own PR with a wider call-site audit.