.buildkite/scripts: derive affected package list from git diff - #20926
Open
efd6 wants to merge 1 commit into
Open
.buildkite/scripts: derive affected package list from git diff#20926efd6 wants to merge 1 commit into
efd6 wants to merge 1 commit into
Conversation
efd6
added
enhancement
Contributor
🚀 Benchmarks reportPackage
|
| Data stream | Previous EPS | New EPS | Diff (%) | Result |
|---|---|---|---|---|
powershell_operational |
2808.99 | 1674.48 | -1134.51 (-40.39%) | 💔 |
To see the full report comment with /test benchmark fullreport
Contributor
Author
|
/test |
1 similar comment
Contributor
Author
|
/test |
efd6
marked this pull request as ready for review
August 27, 2026 04:19
|
Pinging @elastic/ecosystem (Team:Ecosystem) |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
Author
|
The test failures here are due to infrastructure flakiness. |
![vera-review-bot[bot]](https://avatars.githubusercontent.com/in/3297022?s=60&v=4){kind=small}
Replace the linear scan of all packages with a diff-derived candidate list. Before the loop, compute the merge base and changed files once, then extract affected package paths with grep. Only iterate those packages instead of all 486. Fall back to the full list_all_directories scan when non-package files are changed or FORCE_CHECK_ALL is set. Export COMMIT_MERGE so is_pr_affected can reuse it instead of re-running git merge-base for each candidate package. Applied to both trigger_integrations_in_parallel.sh and test_integrations_with_serverless.sh.
efd6
force-pushed
the
check_changed_packages
branch
from
August 27, 2026 04:33
7d9cde0 to
66e1507
Compare
|
🟢 Reviewed the latest commits 66e1507 — nothing new beyond already posted comments. Review summaryIssues found across the latest commits 7d9cde0 — 2 critical
🤖 AI-Generated Review | Vera Review Bot - v0.2.7 | 📚 Knowledge base: integration-skills
|
teresaromero
approved these changes
Aug 27, 2026
teresaromero
left a comment
teresaromero
left a comment
Contributor
There was a problem hiding this comment.
minor comment. thanks!!
| changed_files=$(git diff --name-only "${COMMIT_MERGE}" "${to}") | ||
|
|
||
| if [[ "${FORCE_CHECK_ALL}" == "true" ]] || echo "${changed_files}" | pr_has_package_related_files; then | ||
| echo "Non-package files changed or force-check enabled: scanning all packages" |
Contributor
There was a problem hiding this comment.
Suggested change
| echo "Non-package files changed or force-check enabled: scanning all packages" | |
| echo "Non-package files changed or FORCE_CHECK_ALL set: scanning all packages" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
Related issues
Screenshots