Remove double close in pmd_open_series - #28
Merged
Merged
Conversation
Combine the file handle ownership fix with the padding detection from master: the non-pattern open now records the padding source file and then hands the handle to the series or closes it, and the pattern branch rejects a group-based match before its single close.
electronsandstuff
force-pushed
the
pierce/double-close
branch
from
September 17, 2026 19:54
ebacaa8 to
894920b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolve issue #21
This PR addresses the HDF5 double close which can happen in
pmd_open_serieswhen opening a file-based series through a non-patterned file name.read_series_metadata_from_filecloses the HDF5 file on its own. This PR changes it so that file handle lifetime is managed only bypmd_open_series.