Skip to content

Cleanup: Update headerbar - #2812

Draft
jeremypw wants to merge 6 commits into
mainfrom
jeremypw/update-on-active-miller-only
Draft

Cleanup: Update headerbar#2812
jeremypw wants to merge 6 commits into
mainfrom
jeremypw/update-on-active-miller-only

Conversation

@jeremypw

@jeremypw jeremypw commented Aug 22, 2026

Copy link
Copy Markdown
Contributor

Start to simplify keeping the headerbar in sync without calling update_headerbar many times unnecessarily.

  • Merge another related function into update headerbar
  • Only necessary to connect to the active signal for Miller views as only these can change location without loading
  • Fixed keeping track of restoring_tabs and added another condition for ignoring update_headerbar
  • Stop triggering a load (and update) when a window is associated with a view container - it is unnecessary and overloads the function
  • Add some explanatory comments

In passing restoration of the active tab position was fixed. Fixes #2811

Hopefully the rather complicated interface between Window and ViewContainer can be be further simplified in later PRs.

@jeremypw jeremypw added this to the 7.3.3 milestone Aug 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The active tab position is no longer restored

1 participant