Add latte color tag and simplify - #2815
Open
jeremypw wants to merge 1 commit into
Open
Conversation
|
Pantheon uses the palette of colors in a few places, and granite apps too. |
|
(Thank you <3 ) |
Contributor
Author
The recommended way is to use CSS with the elementary stylesheet but that does not work with cell renderers unfortunately. Once we have ported to Gtk4 we should be able to use dynamic views with the file items being widgets which we can then style without having to hardcode the color values. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2814
In order to add a color while not affect users' previously assigned color tags and keeping the context menu widget colors in a sensible order it was necessary to distinguish the button index from the color index.
indexmember to color button pointing to the required color in COLOR_TAGSlattecolor to the end of COLOR_TAGS and document originThe simplification could be done in a separate PR if adding another color is not approved.