Implement: vpc-bot-tourname-notice.md - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-generated from vault spec
notes/vpc-bot-tourname-notice.md.Change Tournament Notice
Currently the scheduler is configured to notify the #competition-corner channel of the active tournament on Tuesdays at midnight. Tournaments will be more sparse going forward, so we should check for an active tournament every day and notify the channel if the active tournament start date is the same day as the current date.
Expanded Spec
Problem
The current scheduling logic in
src/services/scheduler.jsnotifies the#competition-cornerchannel of active tournaments every Tuesday at midnight. Because tournaments are becoming more sparse, this rigid schedule often results in empty notifications or missed announcements. The system should instead check daily for active tournaments that are starting on the current date.Acceptance Criteria
src/services/scheduler.js(currently set to0 0 * * 2).src/services/scheduler.js(currently set to5 0 * * *) to Announce tournaments starting today in both guild.channels: tournament.channelId and COMPETITION_CHANNEL_IDNotes for implementer
COMPETITION_CHANNEL_IDis already imported insrc/services/scheduler.js.src/lib/tournaments/embed.jsorsrc/commands/tournaments/show-active-tournaments.js.