cleanup: env-template drift (.env.example sole starter) - #111
Merged
Merged
Conversation
Point README, ENV_VARS, and SETUP at .env.example and drop the duplicate Quick template. Add the README guardrail stub and remote MCP auth comments to the starter. Co-authored-by: Emerson Gomes <emerson.gomes@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly audit cleanup D (AGGREGATE area D: env-template drift, safety-adjacent).
.env.exampleis now the only starter. Duplicate incomplete copies no longer drift from the reference tables.Changes
.env.example: keep existing trading comments and idempotency lines; add the README guardrail stub (MTDATA_TRADE_GUARDRAILS_ENABLED,MTDATA_TRADE_ALLOWED_SYMBOLS,MTDATA_TRADE_MAX_VOLUME_BY_SYMBOL,MTDATA_TRADE_MAX_RISK_PCT_OF_EQUITY) and commented remote MCP auth (MCP_AUTH_TOKEN,MCP_ALLOWED_HOSTS,MCP_ALLOWED_ORIGINS).docs/ENV_VARS.md: delete the incomplete Quick.envTemplate body; point the intro and Quick section at.env.example. Reference tables and the Trade Guardrails example block are unchanged.README.mdConfiguration: replace the third starter snippet with a link to.env.example.docs/SETUP.md: stop claiming ENV_VARS ships the starter; first-hour snippet is unchanged.Out of scope
No runtime, settings, CI, or trading-behavior changes. No new vars.
Verification
+12/-97)..env.examplecontains the four guardrail stub lines and the three MCP auth comments.Frontend checks and foundation forecast smoke passed on this PR.
Backend tests fail on
tests/forecast/test_backtest_extended.py::TestForecastBacktest::test_gpu_cleanup_runs_for_gpu_backtest_method(cleanup_forecast_gpu_runtimeexpected once, called 0). That same assertion already fails onmain(1836fdf4, run 34147782839). Forecast leftovers are area E and out of scope here.