Conversation
…ssue-61) CyphalUDPInterface now depends on udp::Dispatcher (Join/Leave/Send) rather than udp::Socket; incoming datagrams are pushed in by a Dispatcher implementation (libhypha on target). Adds the application-owned nucleo::cyphal::HyphaUdpDispatcher adapter, updates the GoogleTest suite to MockUDPDispatcher (62/62 pass on LLVM and AppleClang; M4/M7 cross builds pass), and drops the stale TODO.md (issue-62 checklist). AI (DeepSeek V4 Flash 0731): migrated tests to MockUDPDispatcher, deleted TODO.md, verified all presets. Prior AI sessions: dispatcher abstraction, interface, hypha adapter, test suite (see PLAN.md). Human: accepted Xcode license to unblock local builds.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Progress on #61: replaces the
udp::Socketabstraction withudp::DispatcherinCyphalUDPInterface.Summary
CyphalUDPInterfacenow depends onudp::Dispatcher(Join/Leave/Send) instead ofudp::Socket; incoming datagrams are pushed in by the dispatcher implementation (libhypha on target).nucleo::cyphal::HyphaUdpDispatcheradapts libhypha's UDP callback and multicast TX/RX preparation toudp::Dispatcher.Leave()stops local dispatching because libhypha has no unprepare API.MockUDPDispatcher(gmock); still 62/62 injarnax-cyphalalone.Verification
on-host-native-llvm: 21/21 tests passon-host-native-clang: 21/21 tests passon-target-cortex-m4-gcc-arm-none-eabi/on-target-cortex-m7-gcc-arm-none-eabi: build clean./scripts/build-all-presets.py: all working presets pass.on-host-native-gccfails on Darwin only (Homebrew gcc cannot find its own stdlib headers — documented in AGENTS.md; CI runs that job on Linux where it passes).actcould not be run locally (no Docker daemon on this host).Work split
MockUDPDispatcher, deleted staleTODO.md, verified all presets, rebasedissue-61onto currentdevelop.Remaining per #61
CyphalAppontoCyphalUDPInterface(remove inline udpard plumbing)pylink-square-mcp/RTT +yactui./scripts/build-all-presets.shpass before merge