feat!: require Monarch session cookie auth - #96
Merged
Merged
Conversation
Monarch no longer accepts the legacy bearer token, so MONARCH_TOKEN is removed and MONARCH_COOKIE (or monarch.cookie) is now required. Startup fails fast with a clear error when the cookie is missing. Bumps monarch-go to v2.1.0 for NewClientWithCookie.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
==========================================
+ Coverage 64.95% 64.98% +0.03%
==========================================
Files 51 51
Lines 6979 6983 +4
==========================================
+ Hits 4533 4538 +5
+ Misses 2108 2107 -1
Partials 338 338
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Monarch no longer accepts the legacy bearer token, so
MONARCH_TOKENstopped working. This switches itemize to cookie-based auth.monarch-goto v2.1.0 (addsNewClientWithCookie)MONARCH_COOKIE/monarch.cookieis now required;MONARCH_TOKEN/monarch.api_keyare removedconfig.yaml, and CLI help updated with instructions for copying the cookie from DevToolsBreaking change
Users must replace
MONARCH_TOKENwithMONARCH_COOKIE(sessionid=...; csrftoken=...). Release as v0.3.0.Test plan
newMonarchClient(config cookie, env fallback, missing-cookie error)Cookiego test ./... -racepasses