[ESRTEST-31237] Add 'missing' to Elasticsearch's Terms aggregation - #77
Open
sergio-bobillier wants to merge 1 commit into
Open
[ESRTEST-31237] Add 'missing' to Elasticsearch's Terms aggregation#77sergio-bobillier wants to merge 1 commit into
sergio-bobillier wants to merge 1 commit into
Conversation
Adds a 'missing' parameter to Elasticsearch's Terms aggregation. The parameter allows the user to specify a value to be used for documents that do not have the field being aggregated. Without specifying a 'missing' value, documents without the field are excluded from the aggregation. So, this parameter is required if one wants to prevent the exclusion of said documents. Note: To avoid RuboCop's Metrics/ParameterLists and Reek's LongParameterList warnings in the Aggregations class, the keyword arguments for the #terms method are being shortened to **params. This is not done in the Terms class's #initialize method in order to retain Ruby's validation of the keywords.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
missingparameter to Elasticsearch'sTermsaggregation. The parameter allows the user to specify a value to be used for documents that do not have the field being aggregated.Without specifying a
missingvalue, documents without the field are excluded from the aggregation. So, this parameter is required if one wants to prevent the exclusion of said documents.Note: To avoid RuboCop's
Metrics/ParameterListsand Reek'sLongParameterListwarnings in theAggregationsclass, the keyword arguments for the#termsmethod are being shortened to**params. This is not done in theTermsclass'#initializemethod in order to retain Ruby's validation of the keywords.