fix: ui_verify.py hardcoded SSD-mirror path instead of the primary checkout - #578
Open
essentialbit wants to merge 2 commits into
Open
fix: ui_verify.py hardcoded SSD-mirror path instead of the primary checkout#578essentialbit wants to merge 2 commits into
essentialbit wants to merge 2 commits into
Conversation
…eckout Auditing an out-of-sync mirror gives false confidence -- the SSD copy was 2 days stale and byte-different from templates/dashboard.html on the checkout the sensor/live app actually uses. Matches the Path(__file__).resolve().parents[1]-relative convention already used by qa_verify.py/ci_sensor.py so it runs unmodified from any checkout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/ui_verify.pyhardcodedHTML_FILEto the SSD mirror path (/Volumes/Iron 1TBSSD/Claude/FredAI/templates/dashboard.html) instead of resolving relative to its own location.templates/dashboard.html— the script was silently auditing the wrong, out-of-sync file, giving false confidence about the actually-deployed dashboard.Path(__file__).resolve().parents[1]-relative convention already established by sibling scriptsqa_verify.py/ci_sensor.py, so it runs unmodified from any checkout (primary, worktree, or a CI runner).Found while characterizing previously-uncharacterized sensor tooling scripts (
fredai.mdflaggedui_verify.pyas "not yet characterized in a sensor cycle"). Self-directed tooling fix — no feature-backlog consensus gate applies to this class of PR.Test plan
venv/bin/python3 scripts/ui_verify.pyagainst the fixed path — now correctly audits the primary checkout'stemplates/dashboard.html(301 IDs, 228 JS functions found, real results returned instead of failing against a stale/missing file).python3 -c "from main import *; print('Import OK')"— passes.🤖 Generated with Claude Code