chore: recompute_stuck_consensus.py reuses community._gh_delete instead of a duplicate - #596
Open
essentialbit wants to merge 2 commits into
Open
chore: recompute_stuck_consensus.py reuses community._gh_delete instead of a duplicate#596essentialbit wants to merge 2 commits into
essentialbit wants to merge 2 commits into
Conversation
…ad of a duplicate Same sibling-duplicate-GitHub-call class already fixed for gemini_community.py (#593) and the Discussions GraphQL path (#592): this script's own _gh_delete_label() bypassed community.py's shared _gh_delete(), missing its 404-as-success handling and any future retry-on-transient-failure fix (#588) once merged.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scripts/recompute_stuck_consensus.pydefined its own local_gh_delete_label()(barerequests.delete, no status-code check) instead of importingcommunity.py's shared_gh_delete().gemini_community.py(fix: retry gemini_community.py's GitHub calls once on transient network failure #593) and the Discussions GraphQL path (fix: retry Discussions GraphQL calls once on transient network failure #592) — each was an independently-maintained near-duplicate ofcommunity.py's GitHub helpers that missed a fix applied only to the original.community._gh_delete(path), which already treats a 404 (label already gone) as success and will automatically inherit any future retry-on-transient-failure behavior (fix: retry _gh_post/_gh_delete once on transient network failure #588, open) once that merges — no separate patch needed here later.Test plan
PYTHONPATH=. venv/bin/python3 -c "import scripts.recompute_stuck_consensus as m"— imports cleanlyPYTHONPATH=. venv/bin/python3 -c "from main import *"— Import OKgrep -rn "_gh_delete_label"— no remaining referencestests/doesn't exist in this repo)🤖 Generated with Claude Code