Conversation
|
@silentred: GitHub didn't allow me to request PR reviews from the following users: GunaKKIBM. Note that only etcd-io members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: silentred The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: shenmu.wy <shenmu.wy@antfin.com>
c25ea4c to
b896f55
Compare
| // Layer 2 (observed): the live probe reports the version etcd itself | ||
| // advertises — v-less ("3.6.12") — so compare both sides normalized. | ||
| if m.Status.Phase != ecv1alpha1.EtcdMemberReady || | ||
| strings.TrimPrefix(m.Status.CurrentVersion, "v") != strings.TrimPrefix(tc.toVersion, "v") { |
There was a problem hiding this comment.
This is not correct. should compare with m.Spec.Version
2 participants
Resolves #470
We need to unskip
TestEtcdClusterUpgradeafter Recreating workflow is implemented./cc @ahrtr @GunaKKIBM