feat: add new metrics - #5565
Conversation
|
Running this on our mainnet dev canary ( Live from the canary: (all other combinations present at 0) One small suggestion: On cardinality more broadly: this takes a node from 2 series to 18, but a bee node already exposes around 1570, so it works out at roughly a 1% increase. No concern from our side. The |
|
Could we add test cases to TestClassifyTransport and TestTransportTypePriority covering the new transport classifications? Specifically:
|
| []string{connectionTransportLabelName}, | ||
| ) | ||
|
|
||
| handledConnectionCount := prometheus.NewCounterVec( |
There was a problem hiding this comment.
handled_connection_count includes the public label (true/false), but created_connection_count only has transport.
Is there a reason not to include public on created_connection_count as well? In Connect(), we also have the remote multiaddr via stream.Conn().RemoteMultiaddr(), so having public on both would give symmetric visibility for outbound dials.
Checklist
Description
Breaking changes
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
#5506
Screenshots (if appropriate):
AI Disclosure